From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
mingo@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/headers] x86: fix "__udivdi3" [drivers/scsi/aha1542.ko] undefined
Date: Sat, 14 Feb 2009 08:36:06 +0100 [thread overview]
Message-ID: <20090214073606.GB10863@elte.hu> (raw)
In-Reply-To: <4995F979.9040304@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
> James Bottomley wrote:
>> On Fri, 2009-02-13 at 12:14 -0800, H. Peter Anvin wrote:
>>> James Bottomley wrote:
>>>
>>> #define isa_virt_to_bus(x) ((unsigned int)virt_to_phys(x))
>>>
>>> ... if we're going to do that.
>>
>> Actually, it probably wants to become a static inline ... that way the
>> compiler can always verify the promotion and truncation is legal
>> regardless of whether an actual user is compiled or not.
>>
>
> Yes, that's the right thing to do. I'll fix it up and commit a patch.
Yeah, sure - nevertheless i committed the obvious build fix first.
And as i said, the whole pointer magic construct in aha1542 is a borderline
bug, and if anything like that pops up in non-utter-legacy code it should
be cleaned up anyway.
Ingo
prev parent reply other threads:[~2009-02-14 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-bf33a70a73876b163d62612e9567cbac6604ba7e@kernel.org>
2009-02-13 20:14 ` H. Peter Anvin
2009-02-13 21:36 ` James Bottomley
2009-02-13 22:51 ` H. Peter Anvin
2009-02-14 7:36 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090214073606.GB10863@elte.hu \
--to=mingo@elte.hu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®