From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754605AbZBNVmU (ORCPT ); Sat, 14 Feb 2009 16:42:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753443AbZBNVmL (ORCPT ); Sat, 14 Feb 2009 16:42:11 -0500 Received: from mail-bw0-f167.google.com ([209.85.218.167]:36159 "EHLO mail-bw0-f167.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393AbZBNVmJ (ORCPT ); Sat, 14 Feb 2009 16:42:09 -0500 From: Hannes Eder Subject: [PATCH 27/43] drivers/net/sfc: fix sparse warnings: Should it be static? To: netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 14 Feb 2009 22:42:03 +0100 Message-ID: <20090214214111.24377.87888.stgit@vmbox.hanneseder.net> In-Reply-To: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> References: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> User-Agent: StGit/0.14.3.348.gcb02 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Impact: Include header file and include the function under the same condition as in the header file. If CONFIG_SFS_MTD is not defined than the functions 'efx_mtd_remove' and 'efx_mtd_rename' are defined 'static inline' with an empty function body in the header file. Fix this sparse warnings: drivers/net/sfc/mtd.c:204:6: warning: symbol 'efx_mtd_remove' was not declared. Should it be static? drivers/net/sfc/mtd.c:221:6: warning: symbol 'efx_mtd_rename' was not declared. Should it be static? drivers/net/sfc/mtd.c:230:5: warning: symbol 'efx_mtd_probe' was not declared. Should it be static? Signed-off-by: Hannes Eder --- drivers/net/sfc/mtd.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/sfc/mtd.c b/drivers/net/sfc/mtd.c index 665cafb..94c9ed8 100644 --- a/drivers/net/sfc/mtd.c +++ b/drivers/net/sfc/mtd.c @@ -15,6 +15,7 @@ #define EFX_DRIVER_NAME "sfc_mtd" #include "net_driver.h" #include "spi.h" +#include "efx.h" #define EFX_SPI_VERIFY_BUF_LEN 16 @@ -201,6 +202,7 @@ static void efx_mtd_sync(struct mtd_info *mtd) return; } +#ifdef CONFIG_SFC_MTD void efx_mtd_remove(struct efx_nic *efx) { if (efx->spi_flash && efx->spi_flash->mtd) { @@ -266,3 +268,4 @@ int efx_mtd_probe(struct efx_nic *efx) return 0; } +#endif /* CONFIG_SFC_MTD */