Re: [PATCH 1/1] x86_64: fix s3 fail path

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Saturday 14 February 2009, Jiri Slaby wrote:
> Rafael J. Wysocki napsal(a):
> > On Monday 09 February 2009, Jiri Slaby wrote:
> >> As acpi_enter_sleep_state can fail, take this into account in
> >> do_suspend_lowlevel and don't return to the do_suspend_lowlevel's
> >> caller. This would break (currently) fpu status and preempt count.
> >>
> >> Technically, this means use `call' instead of `jmp' and `jmp' to
> >> the `resume_point' after the `call' (i.e. if
> >> acpi_enter_sleep_state returns=fails). `resume_point' will handle
> >> the restore of fpu and preempt count gracefully.
> >>
> >> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> >> Cc: Len Brown <lenb@kernel.org>
> >> Cc: Pavel Machek <pavel@suse.cz>
> >> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> > 
> > What kernel is this patch against?  It doesn't apply to the mainline.
> 
> It is applicable even after
> [PATCH v2 1/1] x86_64: acpi/wakeup_64 cleanup
> from
> http://lkml.org/lkml/2009/2/7/101
> which is not present anywhere so far.

Thanks, I'm going to push both patches through Len, if Ingo doesn't mind.

Rafael