From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
srostedt@redhat.com
Subject: Re: irqflags.h changes
Date: Sun, 15 Feb 2009 00:22:17 +0100 [thread overview]
Message-ID: <20090214232217.GF20477@elte.hu> (raw)
In-Reply-To: <20090214002324.GA22590@x200.localdomain>
* Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Currently, linux/irqflags.h defines local_irq_enable() and friends
> through raw_* counterparts.
>
> Sometimes it defines raw_* counterparts through local_irq_enable() and
> friends.
>
> I'm going to end this subtle joke and make on all archs:
>
> local_irq_enable() via raw_local_irq_enable()
> local_irq_disable() via raw_local_irq_disable()
> local_irq_save() via raw_local_irq_save()
> local_irq_restore() via raw_local_irq_restore() + stuff
> local_save_flags() via raw_local_save_flags()
> irqs_disabled() via raw_irqs_disabled_flags() + stuff
>
> linux/irqflags.h will include asm/irqflags.h unconditionally.
> Arches that don't have asm/irqflags.h will get it through extraction
> from asm/system.h or whatever.
>
> Users will just include <linux/irqflags.h>
>
> Irq tracing will remain the same (it's nop depending on config option,
> after all).
>
> Typechecking will be preserved.
>
> Compilation will be fixed.
>
> And possibly changing some defines into static inlines.
>
> OK?
This is a much welcome cleanup!
Since if this causes a regression anywhere that's going to be lockdep,
can we pick this up into the locking tree - or would you like to carry
it in a separate tree? (the procfs tree isnt appropriate for it i guess)
Ingo
prev parent reply other threads:[~2009-02-14 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 0:23 Alexey Dobriyan
2009-02-14 0:32 ` Alexey Dobriyan
2009-02-14 23:22 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090214232217.GF20477@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srostedt@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®