From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexandre Rostovtsev <tetromino@gmail.com>,
linux-kernel@vger.kernel.org, linux-laptop@vger.kernel.org
Subject: Re: [0/3] lenovo-sl-laptop : new driver for drivers/staging
Date: Sun, 15 Feb 2009 09:29:56 -0300 [thread overview]
Message-ID: <20090215122956.GB7660@khazad-dum.debian.net> (raw)
In-Reply-To: <1234627163.7293.196.camel@violet>
On Sat, 14 Feb 2009, Marcel Holtmann wrote:
> > > Patches against 2.6.29-rc5 will be in following emails.
> > Please submit it to the kernel proper, not the staging tree. Also
> > please just submit it in one patch instead of the split.
>
> I can only second that. This is not a driver that belongs anywhere near
> the staging tree. It should be instead sent to the ACPI mailing list for
> review.
>
> The staging tree should _NOT_ be used as a shortcut for upstream
> inclusion.
I don't think that was what was happening (I should hope nothing can
get promoted from staging without the usual reviews, anyway!), but
whatever.
We will be happy to review the driver in linux-acpi. Submitting it as
a single patch against latest Linus is probably best. Oh, and it
should be checkpatch-clean if it isn't already.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-02-15 12:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 10:12 Alexandre Rostovtsev
2009-02-14 10:16 ` [1/3] lenovo-sl-laptop : driver source Alexandre Rostovtsev
2009-02-14 10:19 ` [2/3] lenovo-sl-laptop : documentation Alexandre Rostovtsev
2009-02-14 10:22 ` [3/3] lenovo-sl-laptop : kconfig etc Alexandre Rostovtsev
2009-02-14 14:52 ` [0/3] lenovo-sl-laptop : new driver for drivers/staging Christoph Hellwig
2009-02-14 15:59 ` Marcel Holtmann
2009-02-15 12:29 ` Henrique de Moraes Holschuh [this message]
2009-02-15 16:35 ` Alexandre Rostovtsev
2009-02-15 18:29 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090215122956.GB7660@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-laptop@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=tetromino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®