Re: [PATCH] security/smack/smack_lsm.c: cleanup kernel-doc

[Randy Dunlap <rdunlap@xenotime.net>]

On Mon, 9 Feb 2009 18:58:25 +0800 Qinghuang Feng wrote:

> Remove comments which refer to nonexistent arguments.
> 
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
> ---
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 0278bc0..02c48ea 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -538,7 +538,6 @@ static int smack_inode_rename(struct inode *old_inode,
>   * smack_inode_permission - Smack version of permission()
>   * @inode: the inode in question
>   * @mask: the access requested
> - * @nd: unused
>   *
>   * This is the important Smack hook.
>   *
> @@ -701,8 +700,7 @@ static int smack_inode_removexattr(struct dentry *dentry, const char *name)
>   * @inode: the object
>   * @name: attribute name
>   * @buffer: where to put the result
> - * @size: size of the buffer
> - * @err: unused
> + * @alloc: unused
>   *
>   * Returns the size of the attribute or an error code
>   */
> 
> --

ACK, but there are lots of other kernel-doc problems in security/smack/
that could stand to be fixed...

Thanks,
---
~Randy