From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757120AbZBPIOH@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757120AbZBPIOH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Feb 2009 03:14:07 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754960AbZBPINw
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 16 Feb 2009 03:13:52 -0500
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:53978
	"EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK)
	by vger.kernel.org with ESMTP id S1751856AbZBPINv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Feb 2009 03:13:51 -0500
Date: Mon, 16 Feb 2009 00:13:35 -0800 (PST)
Message-Id: <20090216.001335.32409431.davem@davemloft.net>
To: ranma+kernel@tdiedrich.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rjw@sisk.pl,
       aabdulla@nvidia.com, yhlu.kernel@gmail.com, jeff@garzik.org,
       pmhahn@titan.lahn.de
Subject: Re: [PATCH 1/1] net: forcedeth:
 f55c21fd9a92a444e55ad1ca4e4732d56661bf2e caused wake-on-lan regression
From: David Miller <davem@davemloft.net>
In-Reply-To: <20090214151200.GA5496@yamamaya.is-a-geek.org>
References: <20090214151200.GA5496@yamamaya.is-a-geek.org>
X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Tobias Diedrich <ranma+kernel@tdiedrich.de>
Date: Sat, 14 Feb 2009 16:12:00 +0100

> commit f55c21fd9a92a444e55ad1ca4e4732d56661bf2e, which was
> introduced to fix the regression tracked at
> http://bugzilla.kernel.org/show_bug.cgi?id=11358
> causes the wake-on-lan mac to be reversed in the shutdown path.
> Apparently the forcedeth situation is rather messy in that the mac
> we need to writeback for a subsequent modprobe to work is exactly
> the reverse of what is needed for proper wake-on-lan.
> 
> The following patch explains the situation in the comments and
> makes the call to nv_restore_mac_addr() conditional (only called if
> we are not really going for poweroff).
...
> Signed-off-by: Tobias Diedrich <ranma+kernel@tdiedrich.de>
> Tested-by: Philipp Matthias Hahn <pmhahn@titan.lahn.de>

Applied, thanks a lot.