From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754269AbZBPUFP (ORCPT ); Mon, 16 Feb 2009 15:05:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751773AbZBPUE7 (ORCPT ); Mon, 16 Feb 2009 15:04:59 -0500 Received: from pfepb.post.tele.dk ([195.41.46.236]:48667 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbZBPUE7 (ORCPT ); Mon, 16 Feb 2009 15:04:59 -0500 Date: Mon, 16 Feb 2009 21:06:51 +0100 From: Sam Ravnborg To: Manish Katiyar Cc: Ingo Molnar , Stefan Richter , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Replace deprecated __initcall with device_initcall and fix whitespaces in kernel/kallsyms.c Message-ID: <20090216200651.GB16721@uranus.ravnborg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 16, 2009 at 09:54:25PM +0530, Manish Katiyar wrote: > Patch to fix coding style whitespace issues and replace __initcall > with device_initcall > > Errors as reported by checkpatch.pl :- > Before: > total: 14 errors, 14 warnings, 487 lines checked > After : > total: 0 errors, 11 warnings, 486 lines checked > > Compile tested binary verified as :- > Before: > text data bss dec hex filename > 2405 4 0 2409 969 kernel/kallsyms.o > After : > text data bss dec hex filename > 2405 4 0 2409 969 kernel/kallsyms.o > > > Signed-off-by: Manish Katiyar You did not fix the "spaces around operators" issue I showed you. And you have not done an intellegent conding-style cleanup as described in another mail by Ingo(*). (*) As your changelog does not say so I assume you did no do it. So please try again and be more critical this time and try to address the issues raised. Thanks, Sam