From: Martin Michlmayr <tbm@cyrius.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Roland McGrath <roland@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: "elf core dump: fix get_user use" breaks mips compilation
Date: Tue, 17 Feb 2009 08:42:50 +0100 [thread overview]
Message-ID: <20090217074250.GE2495@deprecation.cyrius.com> (raw)
In-Reply-To: <20090216233216.GA19484@linux-mips.org>
* Ralf Baechle <ralf@linux-mips.org> [2009-02-16 23:32]:
> Partially expanding get_user() the code basically does this:
>
> int word;
>
> if (access_ok(...))
> __get_user(word, header);
> else
> word = 0;
>
> And gcc is unable to figure out that word will always be assigned to by
> both paths of the if statement. Older gcc versions used to have that
> problem. I can't reproduce your problem with gcc 4.3.2 and I assume
> you're using something older than that?
Yes, gcc 4.1.
--
Martin Michlmayr
http://www.cyrius.com/
next prev parent reply other threads:[~2009-02-17 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 12:01 Martin Michlmayr
2009-02-16 21:25 ` Roland McGrath
2009-02-17 8:15 ` Martin Michlmayr
2009-02-16 23:32 ` Ralf Baechle
2009-02-17 7:42 ` Martin Michlmayr [this message]
2009-02-17 8:15 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217074250.GE2495@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®