From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbZBQMsT (ORCPT ); Tue, 17 Feb 2009 07:48:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750913AbZBQMsK (ORCPT ); Tue, 17 Feb 2009 07:48:10 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:60762 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbZBQMsJ (ORCPT ); Tue, 17 Feb 2009 07:48:09 -0500 Date: Tue, 17 Feb 2009 13:47:39 +0100 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Andrew Morton , Peter Zijlstra , Frederic Weisbecker , Arnaldo Carvalho de Melo , Steven Rostedt Subject: Re: [PATCH 12/15] ftrace: add traceon traceoff commands to enable/disable the buffers Message-ID: <20090217124739.GA25029@elte.hu> References: <20090217051227.957864159@goodmis.org> <20090217051407.422977785@goodmis.org> <20090217103729.GB6602@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > > On Tue, 17 Feb 2009, Ingo Molnar wrote: > > > > > * Steven Rostedt wrote: > > > > > + if (*count != -1) > > > + (*count)--; > > > > minor nit: it's a tiny bit more compact as: > > > > > + if (*count != -1) > > > + --*count; > > Doesn't that move the pointer? Cases like these, I prefer the parenthesis, > because I get confused about C ordering. > > > > > and this: > > > > > return register_tracer(&function_trace); > > > } > > > > > > device_initcall(init_function_trace); > > > + > > > > there should be no newline between device_initcall() and the > > preceding function. (we can think of it as a late attribute of > > the function, attached to the function. We do the same for > > EXPORT_SYMBOL's too, etc.) > > OK, > > Do you want me to rebase, or just send out new "clean up" patches? I already pulled (these are small details, not showstoppers), please do a delta cleanup of those files. ( there's a few other instances of the same kind of problems - please look at the whole file and try to figure out how to make them look nicer. ) Ingo