Re: sync-Regression in 2.6.28.2?

[Nick Piggin <nickpiggin@yahoo.com.au>]

On Monday 16 February 2009 00:42:35 Ralf Hildebrandt wrote:
> * Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>:
> > > This patch seems good to me. If you would care to add a changelog and
> > > Signed-off-by: line, then we could get it merged?
> > >
> > > I am not too sure about this bug. I have reproduced a strange hang with
> > > ext4 (which does include sys_sync and write_cache_pages traces), and
> > > also turned up a lockdep report. Also, we haven't seen any reports of
> > > this problem on other filesystems. So it could be an ext4 bug.
> > >
> > > Your traces also have lots of tasks hung waiting for page lock. It is
> > > possible that wakeups get lost, which is fixed by this commit in
> > > mainline
> > > 777c6c5f1f6e757ae49ecca2ed72d6b1f523c007
> > >
> > > Which might also be your bug.
> > >
> > >
> > > Any chance you can test this patch (as well as the existing patches
> > > you are using to fix write_cache_pages?).
> >
> > I could test 2.6.28.4
>
> Still there in 2.6.28.5 :(

I believe it is basically a deadlock in ext4 due to the cyclic writeback
change.

http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git;a=commitdiff;h=2acf2c261b823d9d9ed954f348b97620297a36b5

ext4 guys, is this correct? Is there a minimal fix that can be made for
.stable kernels?