mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: use dev_printk in quirk message
Date: Wed, 18 Feb 2009 18:45:43 +0100	[thread overview]
Message-ID: <20090218174543.GA19314@elte.hu> (raw)
In-Reply-To: <20090218161957.12773.31822.stgit@bob.kio>


* Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> This patch changes a VIA PCI quirk to use dev_info() rather than printk().
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
>  arch/x86/kernel/pci-dma.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
> index b254285..022833b 100644
> --- a/arch/x86/kernel/pci-dma.c
> +++ b/arch/x86/kernel/pci-dma.c
> @@ -290,8 +290,7 @@ fs_initcall(pci_iommu_init);
>  static __devinit void via_no_dac(struct pci_dev *dev)
>  {
>  	if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI && forbid_dac == 0) {
> -		printk(KERN_INFO
> -			"PCI: VIA PCI bridge detected. Disabling DAC.\n");
> +		dev_info(&dev->dev, "disabling DAC on VIA PCI bridge\n");
>  		forbid_dac = 1;
>  	}
>  }

that's one for Jesse i think - Cc:-ed him.

	Ingo

      reply	other threads:[~2009-02-18 17:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18 16:19 Bjorn Helgaas
2009-02-18 17:45 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090218174543.GA19314@elte.hu \
    --to=mingo@elte.hu \
    --cc=bjorn.helgaas@hp.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®