From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756214AbZBRUT6 (ORCPT ); Wed, 18 Feb 2009 15:19:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752522AbZBRUTu (ORCPT ); Wed, 18 Feb 2009 15:19:50 -0500 Received: from 82-117-125-11.tcdsl.calypso.net ([82.117.125.11]:42683 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbZBRUTt (ORCPT ); Wed, 18 Feb 2009 15:19:49 -0500 Date: Wed, 18 Feb 2009 21:19:45 +0100 From: Pierre Ossman To: Jorg Schummer Cc: linux-kernel@vger.kernel.org, Jorg Schummer Subject: Re: [PATCH] MMC: core/core.c: fixed: delayed_work was never cancelled Message-ID: <20090218211945.669c3e95@mjolnir.ossman.eu> In-Reply-To: <1234877530-28490-1-git-send-email-ext-jorg.2.schummer@nokia.com> References: <1234877530-28490-1-git-send-email-ext-jorg.2.schummer@nokia.com> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.15.3; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Feb 2009 15:32:10 +0200 Jorg Schummer wrote: > The delayed work item mmc_host.detect is now cancelled before flushing > the work queue. This takes care of cases when delayed_work was scheduled > for mmc_host.detect, but not yet placed in the work queue. > > Signed-off-by: Jorg Schummer > --- Do the cancel in the caller instead. The flush routine is supposed to mimic the global workqueue. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption.