From: MinChan Kim <minchan.kim@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2] perfcounters: clean up rotate_percpu
Date: Wed, 18 Feb 2009 21:27:30 +0900 [thread overview]
Message-ID: <20090218212730.dde6942b.minchan.kim@barrios-desktop> (raw)
Ingo implemented rotate function at 235c7fc7c500e4fd1700c4ad01b5612bcdc1b449.
I think he want to implement rotate_percpu but he don't implement it yet.
If we need not it immediately,
It would be better to remove it until we will need it again.
Signed-off-by: MinChan Kim <minchan.kim@gmail.com>
---
kernel/perf_counter.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index ad62965..211b13b 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -970,20 +970,10 @@ static void rotate_ctx(struct perf_counter_context *ctx)
void perf_counter_task_tick(struct task_struct *curr, int cpu)
{
- struct perf_cpu_context *cpuctx = &per_cpu(perf_cpu_context, cpu);
struct perf_counter_context *ctx = &curr->perf_counter_ctx;
- const int rotate_percpu = 0;
- if (rotate_percpu)
- perf_counter_cpu_sched_out(cpuctx);
perf_counter_task_sched_out(curr, cpu);
-
- if (rotate_percpu)
- rotate_ctx(&cpuctx->ctx);
rotate_ctx(ctx);
-
- if (rotate_percpu)
- perf_counter_cpu_sched_in(cpuctx, cpu);
perf_counter_task_sched_in(curr, cpu);
}
--
1.5.4.3
--
Kinds Regards
MinChan Kim
next reply other threads:[~2009-02-18 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 12:27 MinChan Kim [this message]
2009-02-18 12:31 ` Peter Zijlstra
2009-02-18 12:36 ` MinChan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218212730.dde6942b.minchan.kim@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®