From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755278AbZBSSwQ (ORCPT ); Thu, 19 Feb 2009 13:52:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753280AbZBSSwA (ORCPT ); Thu, 19 Feb 2009 13:52:00 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:53180 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbZBSSv7 (ORCPT ); Thu, 19 Feb 2009 13:51:59 -0500 Date: Thu, 19 Feb 2009 13:51:54 -0500 From: Christoph Hellwig To: Steven Rostedt Cc: Atsushi Tsuji , Peter Zijlstra , linux-kernel@vger.kernel.org, Jason Baron , Ingo Molnar , Mathieu Desnoyers , "Frank Ch. Eigler" , Kazuto Miyoshi , linux-mm , Andrew Morton , Nick Piggin , Hugh Dickins Subject: Re: [PATCH] Add tracepoints to track pagecache transition Message-ID: <20090219185154.GA24117@infradead.org> References: <499A7CAD.9030409@bk.jp.nec.com> <1234863220.4744.34.camel@laptop> <499A99BC.2080700@bk.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2009 at 10:24:46AM -0500, Steven Rostedt wrote: > > On Tue, 17 Feb 2009, Atsushi Tsuji wrote: > > > > > > This is rather asymmetric, why don't we care about the offset for the > > > removed page? > > > > > > > Indeed. > > I added the offset to the argument for the removed page and resend fixed patch. > > > > Signed-off-by: Atsushi Tsuji > > Could you package it up in one patch again and resend with [PATCH v2]. > Also make sure to Cc the memory folks, and ask for an Acked-by from them. Well, until we actually get a consumer of those tracepoints, e.g. a ftrace pluging into the tree strong NACK for me. (p.s. I really don't get it why people keep trying to push dead code into the tree)