From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: airlied@linux.ie, benh@kernel.crashing.org,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: Only use DRM_IOCTL_UPDATE_DRAW compat wrapper for compat X86.
Date: Fri, 20 Feb 2009 00:52:58 -0800 (PST) [thread overview]
Message-ID: <20090220.005258.259993381.davem@davemloft.net> (raw)
In-Reply-To: <200902191519.03399.arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 19 Feb 2009 15:19:01 +0100
> On Wednesday 18 February 2009, David Miller wrote:
> > drm: Only use DRM_IOCTL_UPDATE_DRAW compat wrapper for compat X86.
> >
> > Only X86 32-bit uses a different alignment for "unsigned long long"
> > than it's 64-bit counterpart.
> >
> > Therefore this compat translation is only correct, and only needed,
> > when either CONFIG_X86 or CONFIG_IA64.
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
>
> The patch is correct AFAICT, but I'd like to point out that the
> problem could have been avoided (besides using a non-padded layout)
> by using a compat_u64 member in the struct definition instead of
> the packed attribute:
Indeed, David A. showed me compat_u64 et al. and I'm fine with
it being fixed that way too. Feel free to submit a patch :)
prev parent reply other threads:[~2009-02-20 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 9:35 David Miller
2009-02-18 21:59 ` Benjamin Herrenschmidt
2009-02-18 22:05 ` David Miller
2009-02-19 14:19 ` Arnd Bergmann
2009-02-20 8:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090220.005258.259993381.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome