mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jerome Marchand <jmarchan@redhat.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 2/2] ptrace_untrace: fix the SIGNAL_STOP_STOPPED check
Date: Thu, 19 Feb 2009 19:49:28 -0800 (PST)	[thread overview]
Message-ID: <20090220034928.741F6FC2F7@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Friday, 13 February 2009 11:54:42 +0100 <20090213105442.GA24328@redhat.com>

> This bug is ancient too. ptrace_untrace() must not resume the task
> if the group stop in progress, we should set TASK_STOPPED instead.

Right, the change looks correct.

> Unfortunately, we still have problems here:
> 
> 	- if the process/thread was traced, SIGNAL_STOP_STOPPED
> 	  does not necessary means this thread group is stopped.
> 
> 	- ptrace breaks the bookkeeping of ->group_stop_count.

Neither of these should be true today as I understand the code.  So if you
have reason to think these, I must be missing something that is likely to
be relevant to reviewing this change.


Thanks,
Roland

  reply	other threads:[~2009-02-20  3:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 10:54 Oleg Nesterov
2009-02-20  3:49 ` Roland McGrath [this message]
2009-02-20 19:13   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220034928.741F6FC2F7@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvlasenk@redhat.com \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®