From: Ingo Molnar <mingo@elte.hu>
To: Dheeraj Reddy <dheerajr@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: Incorrect #ifdef in arch/x86/mm/pat.c
Date: Fri, 20 Feb 2009 23:58:57 +0100 [thread overview]
Message-ID: <20090220225857.GA6042@elte.hu> (raw)
In-Reply-To: <loom.20090220T223617-127@post.gmane.org>
* Dheeraj Reddy <dheerajr@gmail.com> wrote:
> Hello there,
> The checks for reading /dev/kmem and /dev/mem in arch/x86/mm/pat.c seems to
> be incorrect when CONFIG_STRICT_DEVMEM is set.
> Following patch corrects it.
> The check should always return 1 when CONFIG_STRICT_DEVMEM is not defined,
> similar to what is in drivers/char/mem.c
no - see the comment in pat.c:
/* This check is done in drivers/char/mem.c in case of STRICT_DEVMEM*/
Ingo
prev parent reply other threads:[~2009-02-20 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 22:39 Dheeraj Reddy
2009-02-20 22:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090220225857.GA6042@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=dheerajr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®