From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean Delvare <khali@linux-fr.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Juergen Beisert <j.beisert@pengutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ben Dooks <ben-linux-arm@fluff.org>,
linux-kernel@vger.kernel.org
Subject: Fwd: PCF8583 not detected on RiscPC
Date: Sat, 21 Feb 2009 19:48:14 +0000 [thread overview]
Message-ID: <20090221194814.GA24385@n2100.arm.linux.org.uk> (raw)
Previous mail sent just to Jean:
| Any ideas why the RTC isn't being detected on the ARM RiscPC platform?
|
| Could it be because someone's decided to regress stuff because of having
| an i2c_boardinfo structure without actually first making sure everything
| is converted over?
|
| If yes, what do I need to do to make it work? (IOW, please supply a
| patch to fix the regression or explain in detail what's required to make
| it work.)
To summarise the situation, the bus driver is:
drivers/i2c/busses/i2c-acorn.c
which is not a platform driver. It is not initialised by the platform
code. It does not provide i2c_boarddata or whatever the funky name for
that feature is.
However, PCF8583 got converted to require i2c_boarddata without first
fixing up the platform which uses it, thereby making the driver utterly
useless.
Putting i2c_boarddata into i2c-acorn.c feels wrong.
So, please either revert 02bb584f3b1cfc8188522a4d2c8881b65073a4f1 so
that the regression can be fixed (no RTC on Acorn RiscPC machines) or
provide a patch which fixes this mess that the above change causes.
next reply other threads:[~2009-02-21 19:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 19:48 Russell King - ARM Linux [this message]
2009-02-21 20:41 ` Russell King - ARM Linux
2009-02-22 0:19 ` Alessandro Zummo
2009-02-22 8:28 ` Russell King - ARM Linux
2009-02-22 9:42 ` Alessandro Zummo
2009-02-22 9:51 ` Russell King - ARM Linux
2009-02-22 10:35 ` Alessandro Zummo
2009-02-22 11:26 ` Russell King - ARM Linux
2009-02-22 13:03 ` Alessandro Zummo
2009-02-22 9:52 ` Jean Delvare
2009-02-22 10:22 ` Russell King - ARM Linux
2009-02-22 10:40 ` Jean Delvare
2009-02-22 12:01 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090221194814.GA24385@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=ben-linux-arm@fluff.org \
--cc=j.beisert@pengutronix.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®