From: "Frank Ch. Eigler" <fche@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Avi Kivity <avi@redhat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] tracing/markers: make markers select tracepoints
Date: Sun, 22 Feb 2009 12:38:00 -0500 [thread overview]
Message-ID: <20090222173800.GB9951@redhat.com> (raw)
In-Reply-To: <20090222171344.GC6570@elte.hu>
Hi -
On Sun, Feb 22, 2009 at 06:13:44PM +0100, Ingo Molnar wrote:
> [...]
> > It would be even easier converted to the markers API directly,
> > without the KVMTRACE* macro intermediary:
> >
> > before:
> > KVMTRACE_3D(MSR_READ, &svm->vcpu, ecx, (u32)data,
> > (u32)(data >> 32), handler);
> > after:
> > trace_mark(kvmtrace, "MSR_READ: %p, %08lx, %016Lx\n",
> > &svm->vcpu, ecx, data);
> >
> > All this already "just works".
> except that we are removing markers.
Perhaps that intention should be justified and reexamined, especially
considering the KVMTRACE* macro-replacement solution you suggested is
almost the same.
- FChE
next prev parent reply other threads:[~2009-02-22 17:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 16:34 Frederic Weisbecker
2009-02-20 16:59 ` Randy Dunlap
2009-02-20 17:20 ` Frederic Weisbecker
2009-02-20 17:22 ` Ingo Molnar
2009-02-20 17:29 ` Randy Dunlap
2009-02-20 17:31 ` Frederic Weisbecker
2009-02-20 17:48 ` Ingo Molnar
2009-02-20 18:56 ` Jason Baron
2009-02-21 3:15 ` Frederic Weisbecker
2009-02-21 22:04 ` Frank Ch. Eigler
2009-02-22 17:13 ` Ingo Molnar
2009-02-22 17:38 ` Frank Ch. Eigler [this message]
2009-02-23 10:13 ` Avi Kivity
2009-02-22 3:23 ` KOSAKI Motohiro
2009-02-22 11:37 ` Peter Zijlstra
2009-02-22 16:04 ` Mathieu Desnoyers
2009-02-22 19:17 ` Ingo Molnar
2009-02-23 2:47 ` Mathieu Desnoyers
2009-02-23 8:52 ` Ingo Molnar
2009-02-22 11:43 ` Peter Zijlstra
2009-02-22 12:08 ` Frank Ch. Eigler
2009-02-22 12:14 ` Peter Zijlstra
2009-02-22 12:24 ` Frank Ch. Eigler
2009-02-23 11:11 ` Peter Zijlstra
2009-02-23 15:44 ` Frank Ch. Eigler
2009-02-23 16:22 ` Peter Zijlstra
2009-02-23 17:10 ` Frank Ch. Eigler
2009-02-23 17:23 ` Ingo Molnar
2009-02-24 13:01 ` Frank Ch. Eigler
2009-02-23 17:31 ` Steven Rostedt
2009-02-23 18:32 ` Theodore Tso
2009-02-23 22:16 ` Peter Zijlstra
2009-02-23 22:41 ` Theodore Tso
2009-02-24 8:55 ` Peter Zijlstra
2009-02-23 0:23 ` Steven Rostedt
2009-02-21 5:24 ` [PATCH][RFC] check for select dependency errors on config load Steven Rostedt
2009-02-21 5:58 ` Andrew Morton
2009-02-21 6:08 ` Andrew Morton
2009-02-21 6:20 ` Randy Dunlap
2009-02-21 20:07 ` Steven Rostedt
2009-02-21 20:46 ` [PATCH v2] kconfig: " Steven Rostedt
2009-02-21 20:48 ` Steven Rostedt
2009-02-21 21:51 ` Sam Ravnborg
2009-02-21 21:53 ` Steven Rostedt
2009-02-22 16:23 ` [PATCH][RFC] " Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090222173800.GB9951@redhat.com \
--to=fche@redhat.com \
--cc=avi@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®