mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcie_portdriver: FIX: pcie_port_device_remove (take 2)
Date: Tue, 24 Feb 2009 11:12:58 -0800	[thread overview]
Message-ID: <200902241112.59203.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <m1r61s2znc.fsf_-_@fess.ebiederm.org>

On Friday, February 20, 2009 8:16:07 pm Eric W. Biederman wrote:
> pcie_port_device_remove currently calls the remove method of port
> drivers twice.  Ouch!
>
> We are calling device_for_each_child multiple times for no apparent
> reason.
>
> So make it simple. Place put_device and device_unregister into
> remove_iter, and throw out the rest.  Only call device_for_each_child
> once.
>
> The code is simpler and actually works!
>
> Changelog:
> v2 rebase against the linux-next tree so I don't conflict with Rafael's
>    irq work, and remove the irq handling cleanups as Rafael's patch already
>    made them.

Thanks for rebasing; it's queued up in my linux-next branch now.  If we really 
need this in the stable kernel it'll be a bit painful, since some of these 
structures have changed around a bit...

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2009-02-24 19:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14  4:23 [PATCH] pcie_portdriver: FIX: pcie_port_device_remove Eric W. Biederman
2009-02-19 20:03 ` Andrew Morton
2009-02-19 20:55   ` Eric W. Biederman
2009-02-19 21:47     ` Rafael J. Wysocki
2009-02-19 23:30       ` Eric W. Biederman
2009-02-19 23:53         ` Jesse Barnes
2009-02-20 10:53         ` Rafael J. Wysocki
2009-02-21  4:16           ` [PATCH] pcie_portdriver: FIX: pcie_port_device_remove (take 2) Eric W. Biederman
2009-02-24 19:12             ` Jesse Barnes [this message]
2009-02-25  4:22               ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902241112.59203.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome