From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] block bits for 2.6.29-rc5
Date: Tue, 24 Feb 2009 08:45:55 -0500 [thread overview]
Message-ID: <20090224134555.GA21436@infradead.org> (raw)
In-Reply-To: <20090220072635.GR29783@kernel.dk>
On Fri, Feb 20, 2009 at 08:26:35AM +0100, Jens Axboe wrote:
> It seems to work fine for me, tested with a modified sd that doesn't
> have barrier support and loop:
>
> Filesystem "sdc1": Disabling barriers, trial barrier write failed
> XFS mounting filesystem sdc1
>
> and
>
> Filesystem "loop0": Disabling barriers, trial barrier write failed
> XFS mounting filesystem loop0
>
> No extra failure warnings on the barrier IO itself. What device do you
> see this on?
virtio_blk and loop. bvut I have investigated this further, and the
reason why I still saw the warnings is that xfs does a
blkdev_issue_flush on unomunt which is not protected by the barrier
flag, so it gets issued unconditionally. So we got the additional
warning on unmount. I've sent a patch to make the blkdev_issue_flush
conditionally to fix that issue.
next prev parent reply other threads:[~2009-02-24 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 14:41 Jens Axboe
2009-02-19 18:54 ` Christoph Hellwig
2009-02-19 18:55 ` Jens Axboe
2009-02-20 7:26 ` Jens Axboe
2009-02-24 13:45 ` Christoph Hellwig [this message]
2009-02-20 1:07 ` Andrew Morton
2009-02-20 16:40 ` Jens Axboe
2009-02-20 16:50 ` Miller, Mike (OS Dev)
2009-02-20 16:53 ` Jens Axboe
2009-02-20 18:51 ` Miller, Mike (OS Dev)
2009-02-23 11:09 ` Jens Axboe
2009-02-23 15:00 ` Miller, Mike (OS Dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224134555.GA21436@infradead.org \
--to=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome