From: Nathan Lynch <ntl@pobox.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Markus Metzger <markus.t.metzger@intel.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com,
markus.t.metzger@gmail.com, srostedt@redhat.com
Subject: Re: [patch 1/6] x86, ftrace, hw-branch-tracer: support hotplug cpus
Date: Tue, 24 Feb 2009 15:46:23 -0600 [thread overview]
Message-ID: <20090224154623.0758d692@thinkcentre.lan> (raw)
In-Reply-To: <20090224193622.GA26734@elte.hu>
On Tue, 24 Feb 2009 20:36:22 +0100
Ingo Molnar <mingo@elte.hu> wrote:
>
> * Markus Metzger <markus.t.metzger@intel.com> wrote:
>
> > Support hotplug cpus.
>
> > +static int __cpuinit bts_hotcpu_handler(struct notifier_block *nfb,
> > + unsigned long action, void *hcpu)
> > +{
> > + unsigned int cpu = (unsigned long)hcpu;
> > +
> > + mutex_lock(&bts_tracer_mutex);
>
> This is buggy: CPU hotplug handlers must not sleep (they are
> called with irqs disabled)
I don't think that is the case; the cpu notifier chains are "raw", not
atomic, and the cpu hotplug core doesn't disable irqs while processing
the chains afaict. And there are several current examples of cpu
hotplug callbacks performing sleeping operations (slab and slub,
page_alloc, probably many others).
next prev parent reply other threads:[~2009-02-24 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 9:26 Markus Metzger
2009-02-24 19:36 ` Ingo Molnar
2009-02-24 21:46 ` Nathan Lynch [this message]
2009-02-25 9:01 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224154623.0758d692@thinkcentre.lan \
--to=ntl@pobox.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome