mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
	greg@kroah.com, s.hauer@pengutronix.de,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] mxc: move serial driver init()/exit() to platform_device
Date: Tue, 24 Feb 2009 22:26:22 +0000	[thread overview]
Message-ID: <20090224222622.GC22390@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0902242302300.9200@axis700.grange>

On Tue, Feb 24, 2009 at 11:09:00PM +0100, Guennadi Liakhovetski wrote:
> On Tue, 24 Feb 2009, Russell King - ARM Linux wrote:
> 
> > I really don't like this approach to controlling multiplex pins, which
> > is to setup the SoC pin configuration when the driver is being bound and
> > to remove it when the driver is unbound.
> 
> What do you think about the reasoning given by Sascha here: 
> http://marc.info/?l=linux-arm-kernel&m=123453175927569&w=2 which is power 
> saving?

That kind of power saving methodology is far better being triggered from
the use of the driver, not whether it is loaded or not if and only if it
is appropriate and necessary for the hardware.

For example, if you do this with a serial port which is connected to the
external world, and you're monitoring it, you don't want your monitoring
to see a break condition every time the port is closed and re-opened.

If you talk about an I2S codec, you'd want to configure the SoCs outputs
to the codec to be logic 0 when powering it down because it isn't being
used.

That's all unrelated to whether the driver is loaded or not, or bound to
a device or not.

  reply	other threads:[~2009-02-24 22:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24 15:57 Paulius Zaleckas
2009-02-24 17:26 ` Russell King - ARM Linux
2009-02-24 22:09   ` Guennadi Liakhovetski
2009-02-24 22:26     ` Russell King - ARM Linux [this message]
2009-02-25  9:19   ` Paulius Zaleckas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090224222622.GC22390@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=g.liakhovetski@gmx.de \
    --cc=greg@kroah.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulius.zaleckas@teltonika.lt \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome