From: Justin Chen <jchen@hpdst41.cup.hp.com>
To: linux-arch@vger.kernel.org
Cc: ben-linux@fluff.org, bjorn.helgaas@hp.com,
dan.j.williams@intel.com, justin.chen@hp.com,
kernel@pengutronix.de, kernel@wantstofly.org,
linux-kernel@vger.kernel.org, linux@maxim.org.za,
mcuos.com@gmail.com
Subject: [PATCH 02/15] bitops: Change the bitmap index from int to unsigned long [arm]
Date: Tue, 24 Feb 2009 20:42:52 -0800 (PST) [thread overview]
Message-ID: <200902250442.UAA12563@hpdst41.cup.hp.com> (raw)
Change the index to unsigned long in all bitops for [arm]
Signed-off-by: Justin Chen <justin.chen@hp.com>
Reviewed-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
arch/arm/include/asm/bitops.h | 36 ++++++++++++++++++------------------
arch/arm/lib/changebit.S | 2 +-
arch/arm/lib/clearbit.S | 2 +-
arch/arm/lib/setbit.S | 2 +-
4 files changed, 24 insertions(+), 21 deletions(-)
diff -Nru a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h
--- a/arch/arm/include/asm/bitops.h 2009-02-22 20:19:40.000000000 -0800
+++ b/arch/arm/include/asm/bitops.h 2009-02-24 13:33:52.000000000 -0800
@@ -34,7 +34,7 @@
*
* First, the atomic bitops. These use native endian.
*/
-static inline void ____atomic_set_bit(unsigned int bit, volatile unsigned long *p)
+static inline void ____atomic_set_bit(unsigned long bit, volatile unsigned long *p)
{
unsigned long flags;
unsigned long mask = 1UL << (bit & 31);
@@ -46,7 +46,7 @@
raw_local_irq_restore(flags);
}
-static inline void ____atomic_clear_bit(unsigned int bit, volatile unsigned long *p)
+static inline void ____atomic_clear_bit(unsigned long bit, volatile unsigned long *p)
{
unsigned long flags;
unsigned long mask = 1UL << (bit & 31);
@@ -58,7 +58,7 @@
raw_local_irq_restore(flags);
}
-static inline void ____atomic_change_bit(unsigned int bit, volatile unsigned long *p)
+static inline void ____atomic_change_bit(unsigned long bit, volatile unsigned long *p)
{
unsigned long flags;
unsigned long mask = 1UL << (bit & 31);
@@ -71,7 +71,7 @@
}
static inline int
-____atomic_test_and_set_bit(unsigned int bit, volatile unsigned long *p)
+____atomic_test_and_set_bit(unsigned long bit, volatile unsigned long *p)
{
unsigned long flags;
unsigned int res;
@@ -88,7 +88,7 @@
}
static inline int
-____atomic_test_and_clear_bit(unsigned int bit, volatile unsigned long *p)
+____atomic_test_and_clear_bit(unsigned long bit, volatile unsigned long *p)
{
unsigned long flags;
unsigned int res;
@@ -105,7 +105,7 @@
}
static inline int
-____atomic_test_and_change_bit(unsigned int bit, volatile unsigned long *p)
+____atomic_test_and_change_bit(unsigned long bit, volatile unsigned long *p)
{
unsigned long flags;
unsigned int res;
@@ -151,12 +151,12 @@
/*
* Little endian assembly bitops. nr = 0 -> byte 0 bit 0.
*/
-extern void _set_bit_le(int nr, volatile unsigned long * p);
-extern void _clear_bit_le(int nr, volatile unsigned long * p);
-extern void _change_bit_le(int nr, volatile unsigned long * p);
-extern int _test_and_set_bit_le(int nr, volatile unsigned long * p);
-extern int _test_and_clear_bit_le(int nr, volatile unsigned long * p);
-extern int _test_and_change_bit_le(int nr, volatile unsigned long * p);
+extern void _set_bit_le(unsigned long nr, volatile unsigned long * p);
+extern void _clear_bit_le(unsigned long nr, volatile unsigned long * p);
+extern void _change_bit_le(unsigned long nr, volatile unsigned long * p);
+extern int _test_and_set_bit_le(unsigned long nr, volatile unsigned long * p);
+extern int _test_and_clear_bit_le(unsigned long nr, volatile unsigned long * p);
+extern int _test_and_change_bit_le(unsigned long nr, volatile unsigned long * p);
extern int _find_first_zero_bit_le(const void * p, unsigned size);
extern int _find_next_zero_bit_le(const void * p, int size, int offset);
extern int _find_first_bit_le(const unsigned long *p, unsigned size);
@@ -165,12 +165,12 @@
/*
* Big endian assembly bitops. nr = 0 -> byte 3 bit 0.
*/
-extern void _set_bit_be(int nr, volatile unsigned long * p);
-extern void _clear_bit_be(int nr, volatile unsigned long * p);
-extern void _change_bit_be(int nr, volatile unsigned long * p);
-extern int _test_and_set_bit_be(int nr, volatile unsigned long * p);
-extern int _test_and_clear_bit_be(int nr, volatile unsigned long * p);
-extern int _test_and_change_bit_be(int nr, volatile unsigned long * p);
+extern void _set_bit_be(unsigned long nr, volatile unsigned long * p);
+extern void _clear_bit_be(unsigned long nr, volatile unsigned long * p);
+extern void _change_bit_be(unsigned long nr, volatile unsigned long * p);
+extern int _test_and_set_bit_be(unsigned long nr, volatile unsigned long * p);
+extern int _test_and_clear_bit_be(unsigned long nr, volatile unsigned long * p);
+extern int _test_and_change_bit_be(unsigned long nr, volatile unsigned long * p);
extern int _find_first_zero_bit_be(const void * p, unsigned size);
extern int _find_next_zero_bit_be(const void * p, int size, int offset);
extern int _find_first_bit_be(const unsigned long *p, unsigned size);
diff -Nru a/arch/arm/lib/changebit.S b/arch/arm/lib/changebit.S
--- orig/arch/arm/lib/changebit.S 2009-02-22 20:19:40.000000000 -0800
+++ new/arch/arm/lib/changebit.S 2009-02-24 13:29:19.000000000 -0800
@@ -13,7 +13,7 @@
.text
/* Purpose : Function to change a bit
- * Prototype: int change_bit(int bit, void *addr)
+ * Prototype: int change_bit(unsigned long bit, void *addr)
*/
ENTRY(_change_bit_be)
eor r0, r0, #0x18 @ big endian byte ordering
diff -Nru a/arch/arm/lib/clearbit.S b/arch/arm/lib/clearbit.S
--- orig/arch/arm/lib/clearbit.S 2009-02-22 20:19:40.000000000 -0800
+++ new/arch/arm/lib/clearbit.S 2009-02-24 13:29:19.000000000 -0800
@@ -14,7 +14,7 @@
/*
* Purpose : Function to clear a bit
- * Prototype: int clear_bit(int bit, void *addr)
+ * Prototype: int clear_bit(unsigned long bit, void *addr)
*/
ENTRY(_clear_bit_be)
eor r0, r0, #0x18 @ big endian byte ordering
diff -Nru a/arch/arm/lib/setbit.S b/arch/arm/lib/setbit.S
--- orig/arch/arm/lib/setbit.S 2009-02-22 20:19:40.000000000 -0800
+++ new/arch/arm/lib/setbit.S 2009-02-24 13:29:19.000000000 -0800
@@ -14,7 +14,7 @@
/*
* Purpose : Function to set a bit
- * Prototype: int set_bit(int bit, void *addr)
+ * Prototype: int set_bit(unsigned long bit, void *addr)
*/
ENTRY(_set_bit_be)
eor r0, r0, #0x18 @ big endian byte ordering
next reply other threads:[~2009-02-25 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 4:42 Justin Chen [this message]
2009-02-25 22:41 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902250442.UAA12563@hpdst41.cup.hp.com \
--to=jchen@hpdst41.cup.hp.com \
--cc=ben-linux@fluff.org \
--cc=bjorn.helgaas@hp.com \
--cc=dan.j.williams@intel.com \
--cc=justin.chen@hp.com \
--cc=kernel@pengutronix.de \
--cc=kernel@wantstofly.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mcuos.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome