mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Theodore Tso <tytso@mit.edu>,
	Arjan van de Ven <arjan@infradead.org>,
	Pekka Paalanen <pq@iki.fi>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jason Baron <jbaron@redhat.com>, Martin Bligh <mbligh@google.com>,
	Mathieu Desnoyers <compudj@krystal.dyndns.org>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 2/4] tracing: add event trace infrastructure
Date: Wed, 25 Feb 2009 10:56:23 +0100	[thread overview]
Message-ID: <20090225095623.GB12352@elte.hu> (raw)
In-Reply-To: <20090225014442.7b7b7726.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> Plus...  it's all English-only.

Note that with bin+raw output you can already internationalize 
tracepoints, if you want to.

I havent seen much interest in that, and the default tracing 
output is in English indeed, and the reason is rather 
fundamental: currently we've got 60,000+ kernel function 
symbols, 99% of which are in English.

Do you argue for them to be converted to some i8n format so that 
the trace output becomes readable in other languages as well? 

I.e. do you suggest that this:

>  3)               |  handle_mm_fault() {
>  3)               |    count_vm_event() {
>  3)   0.243 us    |      test_ti_thread_flag();
>  3)   0.754 us    |    }
>  3)   0.249 us    |    pud_alloc();
>  3)   0.251 us    |    pmd_alloc();
>  3)               |    __do_fault() {
>  3)               |      filemap_fault() {
>  3)               |        find_lock_page() {
>  3)               |          find_get_page() {
>  3)   0.248 us    |            test_ti_thread_flag();
>  3)   0.844 us    |          }
>  3)   1.341 us    |        }
>  3)   1.837 us    |      }
>  3)   0.275 us    |	   _spin_lock();
>  3)   0.257 us    |	   page_add_file_rmap();
>  3)   0.233 us    |      native_set_pte_at();

and /proc/kallsysms to be internationalized? Should all oopses 
and warnings that show up in the kernel log be translated as 
well?

I dont think it's realistic - and arguing for anything less and 
singling out tracing would be a double standard.

Currently being able to understand and hack the kernel means 
being able to read some English - and the same holds for trace 
output as well.

The default output of traces is just a mirror image of what is 
the kernel status quo. If the kernel gets internationalized so 
will ftrace be internationalized too.

> > So if you're arguing against specific ftrace plugins, go 
> > ahead (you probably have a fair point there). But please 
> > don't dismiss the while _concept_ of ftrace because of them.
> 
> Where on earth did that come from?
> 
> What I'm arguing against is putting English-only 
> pretty-printers and pretty-parsers on wrong side of int 80.  
> That's all.

Since the concept of a kernel tracing facility being 
self-sufficient and being easy to use is an integral and key 
concept to ftrace, dont you see why people take your suggestions 
as a dismissal of the ftrace concept?

	Ingo

  reply	other threads:[~2009-02-25  9:59 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25  2:56 [PATCH 0/4] [git pull] tip/tracing/ftrace Steven Rostedt
2009-02-25  2:56 ` [PATCH 1/4] tracing: add DEFINE_TRACE_FMT to tracepoint.h Steven Rostedt
2009-02-25  6:27   ` Peter Zijlstra
2009-02-25 13:01     ` Steven Rostedt
2009-02-25 16:09       ` Mathieu Desnoyers
2009-02-25 16:13   ` Mathieu Desnoyers
2009-02-25 16:28     ` Steven Rostedt
2009-02-25 16:33       ` Ingo Molnar
2009-02-25  2:56 ` [PATCH 2/4] tracing: add event trace infrastructure Steven Rostedt
2009-02-25  3:45   ` Andrew Morton
2009-02-25  4:08     ` Steven Rostedt
2009-02-25  4:24       ` Nick Piggin
2009-02-25  4:33       ` Andrew Morton
2009-02-25  5:16         ` Mathieu Desnoyers
2009-02-25  8:11         ` Ingo Molnar
2009-02-25  8:28           ` Andrew Morton
2009-02-25  8:40             ` Ingo Molnar
2009-02-25  9:15               ` Andrew Morton
2009-02-25  9:00             ` Pekka Enberg
2009-02-25  9:10               ` Ingo Molnar
2009-02-25  9:22               ` Andrew Morton
2009-02-25  9:26                 ` Peter Zijlstra
2009-02-25 10:31                   ` Ingo Molnar
2009-02-25  9:33                 ` Pekka Enberg
2009-02-25  9:44                   ` Andrew Morton
2009-02-25  9:56                     ` Ingo Molnar [this message]
2009-02-25 10:02                       ` Andrew Morton
2009-02-25 10:24                         ` Pekka Enberg
2009-02-25 10:27                         ` Ingo Molnar
2009-02-25 16:21                       ` Frederic Weisbecker
2009-02-25  9:57                     ` Pekka Enberg
2009-02-25 10:07                   ` [PATCH] tracing: remove /debug/tracing/latency_trace Ingo Molnar
2009-02-25 14:41                 ` [PATCH 2/4] tracing: add event trace infrastructure Steven Rostedt
2009-02-25 15:57                   ` Ingo Molnar
2009-02-25 16:09                     ` Steven Rostedt
2009-02-25 22:48                     ` Steven Rostedt
2009-02-26  3:19                       ` Ingo Molnar
2009-02-25 13:54             ` Theodore Tso
2009-02-26 21:08               ` Frank Ch. Eigler
2009-03-01 10:37             ` KOSAKI Motohiro
2009-02-25 13:37     ` Theodore Tso
2009-02-25 14:10       ` Steven Rostedt
2009-02-25  9:07   ` Lai Jiangshan
2009-02-25 13:50     ` Steven Rostedt
2009-02-25  9:21   ` Lai Jiangshan
2009-02-25 13:54     ` Steven Rostedt
2009-02-25  2:56 ` [PATCH 3/4] tracing: add schedule events to event trace Steven Rostedt
2009-02-25  6:29   ` Peter Zijlstra
2009-02-25  2:56 ` [PATCH 4/4] tracing: make event directory structure Steven Rostedt
2009-02-25  6:59   ` Frederic Weisbecker
2009-02-25 13:07     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225095623.GB12352@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=compudj@krystal.dyndns.org \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=jbaron@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@google.com \
    --cc=mhiramat@redhat.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=peterz@infradead.org \
    --cc=pq@iki.fi \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®