From: Arnd Bergmann <arnd@arndb.de>
To: hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
hpa@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [tip:core/header-fixes] compiler-gcc4: conditionalize #error on __KERNEL__
Date: Thu, 26 Feb 2009 01:21:18 +0100 [thread overview]
Message-ID: <200902260121.18610.arnd@arndb.de> (raw)
In-Reply-To: <tip-442405f292c9f9e043afc2243a5b4128f2704c49@kernel.org>
On Thursday 26 February 2009, H. Peter Anvin wrote:
> compiler-gcc4: conditionalize #error on __KERNEL__
>
> Impact: Fix for exported headers
>
> We only want to error out on specific gcc versions if we are actually
> building the kernel, so conditionalize the #if...#error on __KERNEL__.
>
> Based on a patchset by Arnd Bergmann <arnd@arndb.de>.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
No kidding. It never occurred to me that this hunk from my patch was
any good. It just happened that I was cross compiling for powerpc
and only had a ppc64-gcc-4.1.0 installed on my laptop, so I commented
out that line with the intention of reverting that change after a
successful build...
Good catch!
Arnd <><
parent reply other threads:[~2009-02-26 0:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tip-442405f292c9f9e043afc2243a5b4128f2704c49@kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902260121.18610.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome