From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755766AbZBZAxq (ORCPT ); Wed, 25 Feb 2009 19:53:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751412AbZBZAxg (ORCPT ); Wed, 25 Feb 2009 19:53:36 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:53463 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbZBZAxf convert rfc822-to-8bit (ORCPT ); Wed, 25 Feb 2009 19:53:35 -0500 From: Arnd Bergmann To: "H. Peter Anvin" Subject: Re: [patch 0/7] Use strict kernel types to fix the world Date: Thu, 26 Feb 2009 01:52:22 +0100 User-Agent: KMail/1.9.9 Cc: Sam Ravnborg , Kyle McMartin , Ingo Molnar , Jaswinder Singh Rajput , mingo@redhat.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <20090225235138.062045835@arndb.de> <200902260124.13641.arnd@arndb.de> <49A5E28F.5050209@zytor.com> In-Reply-To: <49A5E28F.5050209@zytor.com> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]>=?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200902260152.23410.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX18KTv+ZdexiipUBp3e5HPWiY4LXY3OqGkCMLge I49bGJRFPRcMaJvQpJNYGqbP/jTQ7Z79vFEmrtqN7op96jKODo ymzq/cWKXhqwqNBk6oatg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 26 February 2009, H. Peter Anvin wrote: > I'm really of two minds regarding the patches that replace pure data > types (2/7-5/7).  Part of me thinks it would be better to do this via a > script in make headers_install, but another part of me thinks that that > is a recipe for missing includes. > > However, if subsystem maintainers are sharing headers with other > platforms, it's probably the only sane road to go. The only file I found that is obviously shared across operating systems is linux/coda.h, and I completely left that one alone on the basis that the hacks in there should still work with the new linux/types.h. Doing an automated conversion on coda.h would guarantee trouble, which I see as an argument for doing the manual approach in general. The changes outside of mtd, netfilter, drm and pfkeyv2.h are actually pretty minimal. For reference, all other patches touching those files since 2.6.28 have a combined diffstat of include/drm/drm.h | 26 +++- include/drm/drm_mode.h | 271 ++++++++++++++++++++++++++++++++ include/drm/i915_drm.h | 43 +++++- include/linux/agpgart.h | 1 - include/linux/cyclades.h | 2 - include/linux/dvb/audio.h | 5 - include/linux/dvb/video.h | 7 +- include/linux/if_pppol2tp.h | 2 +- include/linux/matroxfb.h | 2 +- include/linux/mroute6.h | 26 +++- include/linux/netfilter/x_tables.h | 2 +- include/linux/netfilter/xt_conntrack.h | 1 + include/linux/pkt_sched.h | 18 ++ include/linux/ppp_defs.h | 2 + include/linux/time.h | 1 + include/linux/types.h | 24 ++-- include/linux/xfrm.h | 14 ++ include/mtd/inftl-user.h | 2 + include/mtd/ubi-user.h | 134 +++++++++++++--- include/sound/asound.h | 1 + 20 files changed, 530 insertions(+), 54 deletions(-) As long as the netfilter, mtd and drm maintainers agree, I don't see anything holding up the convert-everything-now approach. Arnd <><