From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128AbZCBUnT (ORCPT ); Mon, 2 Mar 2009 15:43:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751618AbZCBUnG (ORCPT ); Mon, 2 Mar 2009 15:43:06 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:49534 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbZCBUnF (ORCPT ); Mon, 2 Mar 2009 15:43:05 -0500 Date: Mon, 2 Mar 2009 20:42:39 +0000 From: Russell King - ARM Linux To: Christian Hohnstaedt , Herbert Xu , karl@hiramoto.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk Subject: Re: [PATCH] crypto: fix handling of sg buffers in ixp4xx driver Message-ID: <20090302204239.GC25699@n2100.arm.linux.org.uk> References: <20090226232025.GE5811@n2100.arm.linux.org.uk> <20090227005033.GA20046@gondor.apana.org.au> <20090302114511.GE6283@elara.bln.innominate.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090302114511.GE6283@elara.bln.innominate.local> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2009 at 12:45:12PM +0100, Christian Hohnstaedt wrote: > > - keep dma functions away from chained scatterlists. > Use the existing scatterlist iteration inside the driver > to call dma_map_single() for each chunk and avoid dma_map_sg(). Hmm, interesting. So crypto has its own scatterlist chaining stuff which is different and incompatible from what is supported by the rest of the kernel. That's really confusing. There's know way to know whether a struct scatterlist should be walked by using the scatterwalk_* stuff or the generic stuff. Excellent for reviewing. So, sorry, I'm not qualified to review this. Please find someone else who knows about crypto stuff.