mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Cedric Roux <sed@free.fr>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
	mtk.manpages@gmail.com, linux-api@vger.kernel.org
Subject: Re: [PATCH] [retry] vt: add ioctl commands to /dev/vcsaN to get/put the current palette of the given tty
Date: Wed, 4 Mar 2009 14:16:35 -0800	[thread overview]
Message-ID: <20090304141635.fa756831.akpm@linux-foundation.org> (raw)
In-Reply-To: <427911.793301236157128303.JavaMail.root@spooler2-g27.priv.proxad.net>

On Wed, 4 Mar 2009 09:58:48 +0100 (CET)
Cedric Roux <sed@free.fr> wrote:

> From: Cedric Roux <sed@free.fr>
> 
> A ioctl interface and two ioctl commands added to /dev/vcsaN
> to get/put the current palette of the given tty.
> 
> ...
>
> - lock_kernel() is called. Maybe it's not necessary? I'm not
>   confident enough. You decide.

I wouldn't have a clue what it's protecting in there.  But it seems
sane to put it in - once someone gets down and de-lock_kernel()s that
code, they can work out what it should be replaced by.


  reply	other threads:[~2009-03-04 22:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  8:58 Cedric Roux
2009-03-04 22:16 ` Andrew Morton [this message]
2009-04-14  9:57 ` [PATCH] [try 3] " Cedric Roux
2009-05-14  7:20   ` Cedric Roux
2009-05-14  7:27     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090304141635.fa756831.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=sed@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome