From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755419AbZCDR3R (ORCPT ); Wed, 4 Mar 2009 12:29:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753526AbZCDR3B (ORCPT ); Wed, 4 Mar 2009 12:29:01 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47419 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753481AbZCDR3A (ORCPT ); Wed, 4 Mar 2009 12:29:00 -0500 Date: Wed, 4 Mar 2009 18:28:58 +0100 From: Jan Kara To: Peter Zijlstra Cc: Frank van Maarseveen , linux-kernel@vger.kernel.org, dm-devel@redhat.com, Alasdair G Kergon , Linus Torvalds , Ingo Molnar Subject: Re: 2.6.27.14: BUG: lock held when returning to user space! Message-ID: <20090304172858.GD8748@atrey.karlin.mff.cuni.cz> References: <20090225142136.GA29505@janus> <1235579389.4645.3621.camel@laptop> <20090304165830.GC8748@atrey.karlin.mff.cuni.cz> <1236186484.5330.8185.camel@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1236186484.5330.8185.camel@laptop> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, 2009-03-04 at 17:58 +0100, Jan Kara wrote: > > > On Wed, 2009-02-25 at 15:21 +0100, Frank van Maarseveen wrote: > > > > An lvextend -L+16G command for a logical volume while being mounted rw > > > > as ext3 triggered the following on 2.6.27.14: > > > > > > > > ================================================ > > > > [ BUG: lock held when returning to user space! ] > > > > ------------------------------------------------ > > > > lvextend/29191 is leaving the kernel with locks still held! > > > > 2 locks held by lvextend/29191: > > > > #0: (&type->s_umount_key #15){....}, at: [] get_super+0x6b/0xb0 > > > > #1: (&journal->j_barrier){....}, at: [] journal_lock_updates+0xc3/0xd0 > > > > > > Do recent kernels still say this? > > > > I'd say so. We really hold j_barrier mutex when leaving the kernel > > after FIFREEZE ioctl (the call path goes as freeze_bdev -> ext3_freeze > > -> journal_lock_updates) until FITHAW is called. As far as I know it was > > designed this way... > > It would be a pity to completely exclude j_barrier mutex from lockdep > > control so would it be possible to mark the mutex (or even that > > particular acquisition of the mutex) so that lockdep does not warn when > > we return with it to userspace? > > Linus specificly stated that we are not to keep locks held when > returning to userspace: > > http://lkml.org/lkml/2007/10/27/135 > > So sure, we could annotate this, but no I won't until you can convince > both me and Linus that its a sane thing to do. I didn't write the code ;). I was just informing how the things are. I agree it's not a nice thing to do. Hmm, looking at the code, it uses a special semaphore bd_mount_sem while mutex seems to be enough. Digging in git... ah, exactly so that lockdep does not complain about it. Ugh. Also the comment before freeze_bdev() says something about taking s_umount while it does not take it. That code really seems to need some cleaning... > The problems include: how can you be sure its the same task calling the > completing ioctl? Yeah, I understand the problems. Honza -- Jan Kara SuSE CR Labs