From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754485AbZCFL6v (ORCPT ); Fri, 6 Mar 2009 06:58:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751298AbZCFL6m (ORCPT ); Fri, 6 Mar 2009 06:58:42 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:35815 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbZCFL6l (ORCPT ); Fri, 6 Mar 2009 06:58:41 -0500 Date: Fri, 6 Mar 2009 12:58:22 +0100 From: Ingo Molnar To: Frederic Weisbecker Cc: Andrew Morton , Lai Jiangshan , Linus Torvalds , Steven Rostedt , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5 v2] Binary ftrace_printk Message-ID: <20090306115822.GB18798@elte.hu> References: <49af5ecb.1c07d00a.32d5.2f45@mx.google.com> <20090306105217.GB5988@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090306105217.GB5988@nowhere> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker wrote: > On Thu, Mar 05, 2009 at 05:53:58AM +0100, Frederic Weisbecker wrote: > > > > This new iteration addresses Steven's reviews. > > Notably: > > > > - only build the ftrace_printk format section if CONFIG_TRACING is set > > - be scheduler tracing safe (don't use preempt_enable directly from > > ftrace_printk to avoid tracing recursion) > > - fix a loss of format string when a module is unloaded. Since we can loose > > it on the ring-buffer if it is in overwrite mode, we don't keep track > > of the format given by the modules to free them. We just copy their > > ftrace_printk string format forever. Note that it is safe against duplicate > > strings since we verify if the string is already present in our list before > > allocating a new one. > > > > --- > > > tip:master has seen some changes concerning the tracing bits > since this patchset submission, notably the movement of > ftrace_printk to include/kernel.h > > These patches probably won't anymore apply properly. Do you > want me to rebase them against latest tip/master? Yeah, please do. (Would there be a way for you to submit via tools that preserve the email-threading of the patches? Right now your mails come in separate threads each.) > Or perhaps you prefer to wait for a Acked-by from Linus or > Andrew? The current lineup looks pretty good to me. Patch #1 is what modifies lib/vsprintf.c and unless Linus or Andrew objects i plan to put that into tip:core/printk so that it's not embedded in the tracing tree and sent upstream separately. Then i'll merge that branch into the tracing tree and apply patches #2...#5. So as long as you send against tip:master (i.e. against the latest tracing bits) i'll be able to sort it out neatly. Ingo