From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756036AbZCFVZI (ORCPT ); Fri, 6 Mar 2009 16:25:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754743AbZCFVYz (ORCPT ); Fri, 6 Mar 2009 16:24:55 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:43092 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754459AbZCFVYz (ORCPT ); Fri, 6 Mar 2009 16:24:55 -0500 Date: Fri, 6 Mar 2009 13:24:38 -0800 From: Andrew Morton To: "hartleys" Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, alex@digriz.org.uk, vitalywool@gmail.com Subject: Re: [PATCH] mtd: plat_nand: add platform probe/remove callbacks Message-Id: <20090306132438.e55fef0d.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Mar 2009 18:58:12 -0500 "hartleys" wrote: > From: "hartleys" You might want to change your email setup so that the above reads "H Hartley Sweeten " or whatever. Because most patch-merging people's tools will end up marking this commit as being from someone called "hartleys". Alternatively, put an explicit From: line at the top of the changelog. > To: > Cc: , "Alexander Clouter" , "Andrew Morton" , > Subject: [PATCH] mtd: plat_nand: add platform probe/remove callbacks > Date: Thu, 5 Mar 2009 18:58:12 -0500 > > Add optional probe and remove callbacks to the plat_nand driver. > > Some platforms may require additional setup, such as configuring > the memory controller, before the nand device can be accessed. > This patch provides an optional callback to handle this setup as > well as a callback to teardown the setup. > > This patch was originally submitted to linux-mtd but it was > suggested I post it here for a broader review. Looks OK to me, but I'm an MTD ignoramus. > Signed-off-by: H Hartley Sweeten > Tested-By: Alexander Clouter > > --- > > diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c > index 75f9f48..600fbe9 100644 The patch was quite wordwrapped. Please fix your email client for next time.