mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
	"roland@redhat.com" <roland@redhat.com>,
	"eranian@googlemail.com" <eranian@googlemail.com>,
	"oleg@redhat.com" <oleg@redhat.com>,
	"Villacis, Juan" <juan.villacis@intel.com>,
	"ak@linux.jf.intel.com" <ak@linux.jf.intel.com>
Subject: Re: [patch 1/4] x86, bts: add selftest for BTS
Date: Fri, 6 Mar 2009 16:23:49 +0100	[thread overview]
Message-ID: <20090306152349.GC12066@elte.hu> (raw)
In-Reply-To: <928CFBE8E7CB0040959E56B4EA41A77E4A5A120A@irsmsx504.ger.corp.intel.com>


* Metzger, Markus T <markus.t.metzger@intel.com> wrote:

> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@elte.hu]
> >Sent: Friday, March 06, 2009 3:33 PM
> >To: Metzger, Markus T
> 
> 
> >> +#ifdef CONFIG_X86_DS_SELFTEST
> >> +static int ds_selftest_bts_consistency(const struct bts_trace *trace)
> >
> >Consider putting this into ds_selftest.c instead of adding a
> >large #ifdef block to ds.c.
> 
> 
> Thanks for your comments.
> 
> I will correct the style problems, move this into 
> ds_selftest.c, and resend the entire series next week.

Thanks! I picked up the .29 items, so there's no rush.

	Ingo

      reply	other threads:[~2009-03-06 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05 15:17 Markus Metzger
2009-03-06 14:32 ` Ingo Molnar
2009-03-06 15:15   ` Metzger, Markus T
2009-03-06 15:23     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090306152349.GC12066@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@linux.jf.intel.com \
    --cc=eranian@googlemail.com \
    --cc=hpa@zytor.com \
    --cc=juan.villacis@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@gmail.com \
    --cc=markus.t.metzger@intel.com \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®