From: Yu Zhao <yu.zhao@intel.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 3/7] PCI: reserve bus range for SR-IOV device
Date: Mon, 9 Mar 2009 16:13:37 +0800 [thread overview]
Message-ID: <20090309081337.GB4638@yzhao-otc.sh.intel.com> (raw)
In-Reply-To: <20090306202024.GF25995@parisc-linux.org>
On Sat, Mar 07, 2009 at 04:20:24AM +0800, Matthew Wilcox wrote:
> On Fri, Feb 20, 2009 at 02:54:44PM +0800, Yu Zhao wrote:
> > +static inline void virtfn_bdf(struct pci_dev *dev, int id, u8 *busnr, u8 *devfn)
> > +{
> > + u16 bdf;
> > +
> > + bdf = (dev->bus->number << 8) + dev->devfn +
> > + dev->sriov->offset + dev->sriov->stride * id;
> > + *busnr = bdf >> 8;
> > + *devfn = bdf & 0xff;
> > +}
>
> I find the interface here a bit clunky -- a function returning void
> while having two OUT parameters. How about this variation on the theme
> (viewers are encouraged to come up with their own preferred
> implementations and interfaces):
>
> static inline __pure u16 virtfn_bdf(struct pci_dev *dev, int id)
> {
> return (dev->bus->number << 8) + dev->devfn + dev->sriov->offset +
> dev->sriov->stride * id;
> }
>
> #define VIRT_BUS(dev, id) (virtfn_bdf(dev, id) >> 8)
> #define VIRT_DEVFN(dev, id) (virtfn_bdf(dev, id) & 0xff)
>
> We rely on GCC to do CSE and not actually invoke virtfn_bdf more than
> once.
Yes, that's a good idea. Will replace that function with macros.
next prev parent reply other threads:[~2009-03-09 8:12 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 6:54 [PATCH v10 0/7] PCI: Linux kernel SR-IOV support Yu Zhao
2009-02-20 6:54 ` [PATCH v10 1/7] PCI: initialize and release SR-IOV capability Yu Zhao
2009-03-06 20:08 ` Matthew Wilcox
2009-03-06 22:03 ` Randy Dunlap
2009-03-06 23:31 ` Duyck, Alexander H
2009-03-07 2:38 ` Greg KH
2009-03-10 1:19 ` Yu Zhao
2009-03-11 4:36 ` Greg KH
2009-03-09 8:12 ` Yu Zhao
2009-02-20 6:54 ` [PATCH v10 2/7] PCI: restore saved SR-IOV state Yu Zhao
2009-03-06 20:09 ` Matthew Wilcox
2009-02-20 6:54 ` [PATCH v10 3/7] PCI: reserve bus range for SR-IOV device Yu Zhao
2009-03-06 20:20 ` Matthew Wilcox
2009-03-09 8:13 ` Yu Zhao [this message]
2009-03-09 18:09 ` Randy Dunlap
2009-03-09 18:11 ` Matthew Wilcox
2009-02-20 6:54 ` [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver Yu Zhao
2009-03-06 20:37 ` Matthew Wilcox
2009-03-06 21:48 ` Randy Dunlap
2009-03-09 8:29 ` Yu Zhao
2009-03-07 2:40 ` Greg KH
2009-03-09 8:25 ` Yu Zhao
2009-03-09 19:39 ` Greg KH
2009-03-10 1:37 ` Yu Zhao
2009-03-11 4:34 ` Greg KH
2009-02-20 6:54 ` [PATCH v10 5/7] PCI: handle SR-IOV Virtual Function Migration Yu Zhao
2009-03-06 21:13 ` Matthew Wilcox
2009-03-09 8:28 ` Yu Zhao
2009-02-20 6:54 ` [PATCH v10 6/7] PCI: document SR-IOV sysfs entries Yu Zhao
2009-03-06 21:16 ` Matthew Wilcox
2009-03-06 22:35 ` Randy Dunlap
2009-02-20 6:54 ` [PATCH v10 7/7] PCI: manual for SR-IOV user and driver developer Yu Zhao
2009-03-06 21:17 ` Matthew Wilcox
2009-02-24 10:47 ` [PATCH v10 0/7] PCI: Linux kernel SR-IOV support Avi Kivity
2009-02-25 1:36 ` Yu Zhao
2009-03-06 19:33 ` Matthew Wilcox
2009-03-08 14:30 ` Avi Kivity
2009-03-08 15:01 ` Matthew Wilcox
2009-03-09 0:45 ` Greg KH
2009-03-09 3:42 ` Yang, Sheng
2009-03-09 4:35 ` Yang, Sheng
2009-03-09 13:45 ` Avi Kivity
2009-03-06 19:44 ` Matthew Wilcox
2009-03-07 2:34 ` Greg KH
2009-03-10 1:11 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309081337.GB4638@yzhao-otc.sh.intel.com \
--to=yu.zhao@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®