From: "Wolfgang Mües" <wolfgang.mues@auerswald.de>
To: "Matt Fleming" <matt@console-pimps.org>
Cc: "Pierre Ossman" <drzeus@drzeus.cx>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Brownell" <dbrownell@users.sourceforge.net>,
"Mike Frysinger" <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] mmc_spi: allow higher timeouts for SPI mode
Date: Wed, 11 Mar 2009 17:14:15 +0100 [thread overview]
Message-ID: <200903111714.15911.wolfgang.mues@auerswald.de> (raw)
In-Reply-To: <20090311154605.GD1475@console-pimps.org>
Matt,
Am Mittwoch, 11. März 2009 schrieb Matt Fleming:
> OK, but if my machine runs at 100 HZ then a jiffie is 10ms.
Yes.
> Previously (without your patch) we waited for 300ms in the write case
> and 100ms in the read case.
It depends... There was a change between somewhere between 2.6.26 (300+100ms)
and 2.6.29 (timeouts calculated from the card parameters).
> So, it's not unreasonable to think that a response is
> going to take more than 10ms.
Mosts responses (data read and data write with empty buffers in the card) are
immediately, mostly below 1 ms.
> With your patch we're almost always going
> to schedule()
No. See above.
> I agree that busy-waiting for 900ms would be a bit mad.
Yes, but this was the previous reality!
> Is there a reason that you didn't implement this with msleep()
> as was noted in the comment above the timeout?
Yes. msleep() is a busy waiting. It is implemented in terms of usleep(), which
is also busy waiting. The old comment is wrong.
> Do you know approximately how long it
> is before we return from the schedule() under various workloads?
The Linux scheduler tend to prefer processes which call schedule() often, so
there is a high chance that this process will return from the schedule() at
the very next tick.
So my timing is:
- busy waiting for 1-2 jiffies
- non-busy-waiting with a delay of 0-1 jiffies afterwards.
I have done some speed measurements for SD card reads and writes, and the
non-busy waiting has not incured a notable speed decrease.
best regards
i. A. Wolfgang Mües
--
Auerswald GmbH & Co. KG
Hardware Development
Telefon: +49 (0)5306 9219 0
Telefax: +49 (0)5306 9219 94
E-Mail: Wolfgang.Mues@Auerswald.de
Web: http://www.auerswald.de
--------------------------------------------------------------
Auerswald GmbH & Co. KG, Vor den Grashöfen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRA 13289
p.h.G Auerswald Geschäftsführungsges. mbH
Registriert beim AG Braunschweig HRB 7463
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
next prev parent reply other threads:[~2009-03-11 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 13:28 Wolfgang Mües
2009-03-11 14:02 ` Matt Fleming
2009-03-11 14:55 ` Wolfgang Mües
2009-03-11 15:46 ` Matt Fleming
2009-03-11 16:14 ` Wolfgang Mües [this message]
2009-03-11 20:17 ` David Brownell
2009-03-12 8:16 ` Wolfgang Mües
2009-03-11 20:15 ` David Brownell
2009-03-15 11:27 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903111714.15911.wolfgang.mues@auerswald.de \
--to=wolfgang.mues@auerswald.de \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®