From: David Brownell <david-b@pacbell.net>
To: "Wolfgang Mües" <wolfgang.mues@auerswald.de>
Cc: Pierre Ossman <drzeus@drzeus.cx>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Matt Fleming" <matt@console-pimps.org>,
"Mike Frysinger" <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] mmc_spi: convert timeout handling to jiffies and avoid busy waiting
Date: Wed, 11 Mar 2009 18:45:22 -0800 [thread overview]
Message-ID: <200903111945.22597.david-b@pacbell.net> (raw)
In-Reply-To: <200903111435.03196.wolfgang.mues@auerswald.de>
On Wednesday 11 March 2009, Wolfgang Mües wrote:
> o SD/MMC card timeouts can be very high. So avoid busy-waiting,
> using the scheduler. Calculate all timeouts in jiffies units,
> because this will give us the correct sign when to involve
> the scheduler.
Of these patches, this is the one that bothers me the most.
First, earlier versions used jiffies ... but switching to
ktime sped things up. (I forget the details by now.)
So it's odd to think that switching again could improve
things. At any rate, if that's worth doing it's worth
having as a separate patch.
Second, as someone previously pointed out, there's a comment
there about switching to sleep() calls ... did you explore
just kicking in schedule_hrtimeout() or somesuch, right at
that point? Heck, just calling schedule() would cut the
busy-wait overhead...
next prev parent reply other threads:[~2009-03-12 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 13:35 Wolfgang Mües
2009-03-12 2:45 ` David Brownell [this message]
2009-03-12 9:33 ` Wolfgang Mües
2009-03-15 11:37 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903111945.22597.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=vapier.adi@gmail.com \
--cc=wolfgang.mues@auerswald.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome