mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <jbeulich@novell.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] eliminate spurious pointless WARN_ON()s
Date: Thu, 12 Mar 2009 13:19:28 +0100	[thread overview]
Message-ID: <20090312121928.GA15972@elte.hu> (raw)
In-Reply-To: <49B90B31.76E4.0078.0@novell.com>


* Jan Beulich <jbeulich@novell.com> wrote:

> Namely during early boot, the panic() or BUG() paths may end 
> up in smp_call_function_*() with just a single online CPU. In 
> that situation the warnings generated are not only 
> meaningless, but also result in relevant output being 
> cluttered.
> 
> Therefore, defer the WARN_ON() checks until after the 
> (unaffected from the problem that is being attempted to be 
> detected here) cases have been handled.

Makes sense probably - but please send a patch against -tip as 
we've got quite many changes queued up in that area and your 
patch does not apply cleanly:

 patching file kernel/smp.c
 Hunk #1 FAILED at 222.
 Hunk #2 FAILED at 229.
 Hunk #3 FAILED at 325.
 Hunk #4 FAILED at 344.
 4 out of 4 hunks FAILED -- rejects in file kernel/smp.c

Thanks,

	Ingo

      reply	other threads:[~2009-03-12 12:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 12:16 Jan Beulich
2009-03-12 12:19 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090312121928.GA15972@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®