From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: feature-removal-schedule.txt for some I2C functions
Date: Thu, 12 Mar 2009 15:06:03 +0100 [thread overview]
Message-ID: <20090312150603.1aecdba9@hyperion.delvare> (raw)
In-Reply-To: <20090312102617.3235a35b@pedra.chehab.org>
Hi Mauro,
On Thu, 12 Mar 2009 10:26:17 -0300, Mauro Carvalho Chehab wrote:
> Hi Jean,
>
> On your entry at Documentation/feature-removal-schedule.txt:
>
> What: i2c_attach_client(), i2c_detach_client(), i2c_driver->detach_client()
> When: 2.6.29 (ideally) or 2.6.30 (more likely)
> Why: Deprecated by the new (standard) device driver binding model. Use
> i2c_driver->probe() and ->remove() instead.
> Who: Jean Delvare <khali@linux-fr.org>
>
> You forgot to add a check entry, like:
> Check: i2c_attach_client i2c_detach_client i2c_driver->detach_client
>
> The check entry is used by checkpatch.pl to warn about the usage of a legacy function.
>
> Please fix it, since me and others rely on this tool to discover about the
> usage of legacy functions.
Thanks for the tip, I didn't know about this. Is there some
documentation about the Check: entry format? If checkpatch.pl simply
matches the strings then i2c_driver->detach_client is never going to
match, so there's no point in adding it.
--
Jean Delvare
prev parent reply other threads:[~2009-03-12 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 13:26 Mauro Carvalho Chehab
2009-03-12 14:06 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312150603.1aecdba9@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome