From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Markus Armbruster <armbru@redhat.com>,
Anders Kaseorg <andersk@MIT.EDU>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Xen-devel] Re: [PATCH] IRQ handling race and spurious IIR read in serial/8250.c
Date: Thu, 12 Mar 2009 21:38:31 +0000 [thread overview]
Message-ID: <20090312213831.5045f5d0@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <18873.25299.416627.13221@mariner.uk.xensource.com>
> 1. It is definitely correct and does not introduce any new bugs.
Right ;)
> 2. It makes the existing bug definitely go away. That is, after my
> patch is applied the code drives the UART correctly - that is,
> according to the specification and in a manner guaranteed to be
The UART hardware and specifications diverge - often quite spectacularly.
> 4. Any fix which does not involve completely removing UART_BUG_TXEN
> will need my change.
Or the locking fix
It was described as a band aid so I treated it as such. Regardless of the
right thing to do long term its not a 2.6.29 candidate at this point but
certainly something that wants looking into in 2.6.30
next prev parent reply other threads:[~2009-03-12 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 17:57 Markus Armbruster
2009-03-12 18:09 ` Alan Cox
2009-03-12 19:30 ` Ian Jackson
2009-03-12 21:38 ` Alan Cox [this message]
[not found] <1233800599.5398.0.camel@balanced-tree>
[not found] ` <18827.7191.646173.99255@mariner.uk.xensource.com>
[not found] ` <1233862446.5676.28.camel@balanced-tree>
[not found] ` <1233870772.5676.40.camel@balanced-tree>
[not found] ` <18833.40557.119090.48930@mariner.uk.xensource.com>
[not found] ` <alpine.DEB.2.00.0902101249181.20723@vinegar-pot.mit.edu>
2009-02-11 16:08 ` Ian Jackson
2009-02-19 17:52 ` Ian Jackson
2009-02-19 18:37 ` [Xen-devel] " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312213831.5045f5d0@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Ian.Jackson@eu.citrix.com \
--cc=akpm@linux-foundation.org \
--cc=andersk@MIT.EDU \
--cc=armbru@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®