From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 3/4] tracing: move binary buffers into per cpu directory
Date: Fri, 13 Mar 2009 01:04:49 -0400 [thread overview]
Message-ID: <20090313050521.535041167@goodmis.org> (raw)
In-Reply-To: <20090313050446.277065036@goodmis.org>
[-- Attachment #1: 0003-tracing-move-binary-buffers-into-per-cpu-directory.patch --]
[-- Type: text/plain, Size: 2269 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The binary_buffers directory in /debugfs/tracing held the files
to read the trace buffers in a binary format. This held one file
per CPU buffer. But we also have a per_cpu directory that holds
a way to read the pretty-print formats.
This patch moves the binary buffers into the per_cpu_directory:
# ls /debug/tracing/per_cpu/cpu1/
trace trace_pipe trace_pipe_raw
The new name is called "trace_pipe_raw". The binary buffers always
acted similar to trace_pipe, except that they produce raw data.
Requested-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace.c | 26 +++++---------------------
1 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index dbb077d..efe3202 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3543,6 +3543,11 @@ static void tracing_init_debugfs_percpu(long cpu)
(void *) cpu, &tracing_fops);
if (!entry)
pr_warning("Could not create debugfs 'trace' entry\n");
+
+ entry = debugfs_create_file("trace_pipe_raw", 0444, d_cpu,
+ (void *) cpu, &tracing_buffers_fops);
+ if (!entry)
+ pr_warning("Could not create debugfs 'trace_pipe_raw' entry\n");
}
#ifdef CONFIG_FTRACE_SELFTEST
@@ -3826,7 +3831,6 @@ static __init void create_trace_options_dir(void)
static __init int tracer_init_debugfs(void)
{
struct dentry *d_tracer;
- struct dentry *buffers;
struct dentry *entry;
int cpu;
@@ -3899,26 +3903,6 @@ static __init int tracer_init_debugfs(void)
pr_warning("Could not create debugfs "
"'trace_marker' entry\n");
- buffers = debugfs_create_dir("binary_buffers", d_tracer);
-
- if (!buffers)
- pr_warning("Could not create buffers directory\n");
- else {
- int cpu;
- char buf[64];
-
- for_each_tracing_cpu(cpu) {
- sprintf(buf, "%d", cpu);
-
- entry = debugfs_create_file(buf, 0444, buffers,
- (void *)(long)cpu,
- &tracing_buffers_fops);
- if (!entry)
- pr_warning("Could not create debugfs buffers "
- "'%s' entry\n", buf);
- }
- }
-
#ifdef CONFIG_DYNAMIC_FTRACE
entry = debugfs_create_file("dyn_ftrace_total_info", 0444, d_tracer,
&ftrace_update_tot_cnt,
--
1.6.1.3
--
next prev parent reply other threads:[~2009-03-13 5:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 5:04 [PATCH 0/4] [GIT PULL] updates for tip/tracing/ftrace Steven Rostedt
2009-03-13 5:04 ` [PATCH 1/4] tracing: left align location header in stack_trace Steven Rostedt
2009-03-13 5:04 ` [PATCH 2/4] tracing: add comment for use of double __builtin_consant_p Steven Rostedt
2009-03-13 5:04 ` Steven Rostedt [this message]
2009-03-13 5:16 ` [PATCH 3/4] tracing: move binary buffers into per cpu directory Andrew Morton
2009-03-13 5:04 ` [PATCH 4/4] softirq: no need to have SOFTIRQ in softirq name Steven Rostedt
2009-03-13 5:17 ` Andrew Morton
2009-03-13 5:40 ` Jaswinder Singh Rajput
2009-03-13 5:30 ` [PATCH 0/4] [GIT PULL] updates for tip/tracing/ftrace Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313050521.535041167@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®