From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] perfcounters: Make s/w counters in a group only count when group is on
Date: Fri, 13 Mar 2009 14:13:09 +0100 [thread overview]
Message-ID: <20090313131309.GB10117@elte.hu> (raw)
In-Reply-To: <1236949440.5188.709.camel@laptop>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, 2009-03-13 at 13:44 +0100, Peter Zijlstra wrote:
>
> > The same for task migration, most migrations happen when
> > they are in fact running, so there too we can account the
> > migration either before we rip it off the src cpu, or after
> > we place it on the dst cpu.
>
> Right, I got confused between being on the cpu and having
> ->state = R.
>
> Migrations are the odd one out indeed, but I'd rather fudge a
> little with the migration counter itself than have this weird
> asymmetry.
Agreed. There should really be no difference between software
and hardware counters as far as the generic perfcounters code
goes. It's a magic "metric" that gets read out somehow, and
which generates events somehow.
We can have various grades of hardware versus software counters:
- 'pure hardware counters' where both the count and events come
from some hw register
- 'pure software counters' where both the count and events are
generated by software
- 'hybride counters' where for example the count might be from a
hardware register, but the event is generated by a hrtimer
(because the hardware is not capable of generating events).
the is_software_counter() assymetry broke this generally relaxed
model of counters.
Ingo
next prev parent reply other threads:[~2009-03-13 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 1:59 Paul Mackerras
2009-03-13 10:23 ` Peter Zijlstra
2009-03-13 12:23 ` Paul Mackerras
2009-03-13 12:44 ` Peter Zijlstra
2009-03-13 13:04 ` Peter Zijlstra
2009-03-13 13:13 ` Ingo Molnar [this message]
2009-03-13 23:43 ` Paul Mackerras
2009-03-13 22:41 ` Paul Mackerras
2009-03-14 11:51 ` Ingo Molnar
2009-03-16 9:56 ` Peter Zijlstra
2009-03-16 10:33 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313131309.GB10117@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®