From: David Brownell <david-b@pacbell.net>
To: Purushotam Kumar <purushotam@ti.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Subject: Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.
Date: Mon, 16 Mar 2009 14:08:45 -0700 [thread overview]
Message-ID: <200903161408.45897.david-b@pacbell.net> (raw)
In-Reply-To: <1237214559-31345-1-git-send-email-purushotam@ti.com>
I noticed a newish bug in probe() ...
On Monday 16 March 2009, Purushotam Kumar wrote:
> + if (!pdata || pdata->wires == 4 || pdata->wires == 0)
> + mmc->caps |= MMC_CAP_4_BIT_DATA;
So pdata may be null. But, if it is, then ...
> +
> + mmc->ops = &mmc_davinci_ops;
> + mmc->f_min = 312500;
> + mmc->f_max = 25000000;
> + if (pdata->max_freq)
> + mmc->f_max = pdata->max_freq;
Oops!
> + if (pdata->caps)
> + mmc->caps |= pdata->caps;
Double oops!
next prev parent reply other threads:[~2009-03-16 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 14:42 Purushotam Kumar
2009-03-16 18:14 ` Trilok Soni
2009-03-17 10:14 ` Kumar, Purushotam
2009-03-16 18:40 ` David Brownell
2009-03-17 7:25 ` Kumar, Purushotam
2009-03-16 21:08 ` David Brownell [this message]
2009-03-17 7:30 ` Kumar, Purushotam
2009-03-22 15:12 ` Pierre Ossman
2009-03-26 8:58 ` Kumar, Purushotam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903161408.45897.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=purushotam@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®