From: David Miller <davem@davemloft.net>
To: mpatocka@redhat.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crash with /proc/iomem on sparc64
Date: Wed, 18 Mar 2009 23:53:31 -0700 (PDT) [thread overview]
Message-ID: <20090318.235331.65960278.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0903170807440.25109@hs20-bc2-1.build.redhat.com>
From: Mikulas Patocka <mpatocka@redhat.com>
Date: Tue, 17 Mar 2009 08:08:08 -0400 (EDT)
>
>
> On Tue, 17 Mar 2009, Mikulas Patocka wrote:
>
> > Hi
> >
> > When you compile kernel on Sparc64 with heap memory checking and type
> > "cat /proc/iomem", you get a crash, because pointers in struct resource
> > are uninitialized.
> >
> > Most code fills struct resource with zeros, so I assume that it is
> > responsibility of the caller of request_resource to initialized it, not
> > the responsibility of request_resource functuion.
> >
> > After 2.6.29 is out, there could be a check for uninitialized fields added
> > to request_resource to avoid crashes like this.
> >
> > Mikulas
>
> I forgot to add:
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Patch applied and queued up for -stable, thanks a lot.
prev parent reply other threads:[~2009-03-19 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 12:03 Mikulas Patocka
2009-03-17 12:08 ` Mikulas Patocka
2009-03-17 13:35 ` Mikulas Patocka
2009-03-17 19:15 ` David Miller
2009-03-19 6:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318.235331.65960278.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome