From: Christoph Hellwig <hch@lst.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Anthony Liguori <aliguori@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: VIRTIO_BLK_T_SCSI_CMD in the virtio-blk protocol
Date: Wed, 18 Mar 2009 07:04:53 +0100 [thread overview]
Message-ID: <20090318060453.GA10650@lst.de> (raw)
Currently when virtio-blk gets a packet command request it just sets
the VIRTIO_BLK_T_SCSI_CMD flag in the type field, a zero sector and
sends down the request payload.
However for packet command requests they payload doesn't really say
anything about the command, we could need the cmd array to specify what
command (and offset/length) we're actually sending.
As far as I can see none of the backends actually implements
VIRTIO_BLK_T_SCSI_CMD support, so no harm is done here.
Should we just remove all handling of this flag until we have proper
support for it? That would most like mean sending down another S/G
sement with the scsi command before the actual data.
Btw, is there a protocol spec for virtio-blk somewhere?
reply other threads:[~2009-03-18 6:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318060453.GA10650@lst.de \
--to=hch@lst.de \
--cc=aliguori@us.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome