these latest ftrace changes caused a lockup on a -tip testsystem: [ 7.639947] Testing tracer irqsoff: PASSED [ 7.644283] Testing tracer preemptoff: PASSED [ 7.648893] Testing tracer preemptirqsoff: <0>BUG: spinlock lockup on CPU#1, rcu_torture_fak/801, ffffffff813c9f30 [ 7.656831] Pid: 801, comm: rcu_torture_fak Not tainted 2.6.29-rc8-tip #20979 [ 7.656831] Call Trace: [ 7.656831] [] _raw_spin_lock+0xf4/0x137 [ 7.656831] [] _spin_lock_irqsave+0x83/0xb1 [ 7.656831] [] ? stop_critical_timing+0x1c7/0x236 [ 7.656831] [] ? ftrace_now+0x4a/0x69 [ 7.656831] [] ? schedule_timeout+0x31/0xfc [ 7.656831] [] stop_critical_timing+0x1c7/0x236 [ 7.656831] [] trace_preempt_on+0x37/0x4d [ 7.656831] [] sub_preempt_count+0x44/0x6e [ 7.656831] [] thread_return+0x97/0xd8 [ 7.656831] [] ? __lock_acquire+0xc7b/0xca1 [ 7.656831] [] schedule_timeout+0x31/0xfc [ 7.656831] [] ? get_parent_ip+0x20/0x67 [ 7.656831] [] ? trace_hardirqs_on_caller+0x14c/0x18f [ 7.656831] [] ? sub_preempt_count+0x44/0x6e [ 7.656831] [] ? trace_hardirqs_on+0x20/0x36 [ 7.656831] [] ? _spin_unlock_irq+0x65/0x89 [ 7.656831] [] wait_for_common+0xb0/0x10d [ 7.656831] [] ? default_wake_function+0x0/0x36 [ 7.656831] [] wait_for_completion+0x2b/0x41 [ 7.656831] [] synchronize_rcu+0x54/0x6f [ 7.656831] [] ? wakeme_after_rcu+0x0/0x36 [ 7.656831] [] ? complete+0x2b/0x71 [ 7.656831] [] rcu_torture_fakewriter+0x98/0x114 [ 7.656831] [] ? rcu_torture_fakewriter+0x0/0x114 [ 7.656831] [] ? rcu_torture_fakewriter+0x0/0x114 [ 7.656831] [] kthread+0x5c/0x9f [ 7.656831] [] child_rip+0xa/0x20 [ 7.656831] [] ? restore_args+0x0/0x30 [ 7.656831] [] ? kthread+0x0/0x9f [ 7.656831] [] ? child_rip+0x0/0x20 config attached. Ingo