mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Anthony Liguori <aliguori@us.ibm.com>,
	linux-kernel@vger.kernel.org, hare@suse.de
Subject: Re: VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk
Date: Wed, 18 Mar 2009 09:47:36 +0100	[thread overview]
Message-ID: <200903180947.36878.borntraeger@de.ibm.com> (raw)
In-Reply-To: <20090318060919.GA21777@infradead.org>

Am Wednesday 18 March 2009 07:09:19 schrieb Christoph Hellwig:
> Currently virtio-blk just sends down the payload for packet command
> requests, setting the VIRTIO_BLK_T_SCSI_CMD flag in the type field and
> zeroing out the sector field.
> 
> But to make any sense of the payload of a packet command we need the
> scsi command block (request->cmd) which specifies the operation,
> location and length for this command.
> 
> All backends that I checked just fail VIRTIO_BLK_T_SCSI_CMD commands, so
> AFAICS no harm is done.  But should we really keep this broken support
> in the protocol around?  If we do want to support packet commands in
> the future we should probably just add the command as the first S/G list
> entry.

Hannes did some implementation for SCSI command passthrough:
https://lists.linux-foundation.org/pipermail/virtualization/2008-August/011629.html

After some addon fix this was working pretty well. I dont know why Hannes never
pushed the final version upstream.

Christian

  parent reply	other threads:[~2009-03-18  8:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18  6:09 Christoph Hellwig
2009-03-18  6:10 ` Christoph Hellwig
2009-03-18  8:47 ` Christian Borntraeger [this message]
2009-03-18  9:16   ` Hannes Reinecke
2009-03-18  9:37     ` Christian Borntraeger
2009-03-18  9:38     ` Christoph Hellwig
2009-03-18 22:47 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903180947.36878.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome