mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
	Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
	Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Joe Korty <joe.korty@ccur.com>
Subject: [patch 02/43] Fix misreporting of #cores as #hyperthreads for Q9550
Date: Fri, 20 Mar 2009 15:28:12 -0700	[thread overview]
Message-ID: <20090320222923.128981119@mini.kroah.org> (raw)
In-Reply-To: <20090320232116.GA3375@kroah.com>

[-- Attachment #1: fix-misreporting-of-cores-as-hyperthreads-for-q9550.patch --]
[-- Type: text/plain, Size: 3728 bytes --]

2.6.28-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Joe Korty <joe.korty@ccur.com>

For the Q9550, in x86_64 mode, /proc/cpuinfo mistakenly
thinks the #cores present is the #hyperthreads present.
i386 mode was not examined but is assumed to have the
same problem.

A backport of the following three 2.6.29-rc1 patches
fixes the problem:

 066941bd4eeb159307a5d7d795100d0887c00442:
    [PATCH] x86: unmask CPUID levels on Intel CPUs
 99fb4d349db7e7dacb2099c5cc320a9e2d31c1ef:
    [PATCH] x86: unmask CPUID levels on Intel CPUs, fix
 bdf21a49bab28f0d9613e8d8724ef9c9168b61b9:
    [PATCH] x86: add MSR_IA32_MISC_ENABLE bits to <asm/msr-index.h>

>From the first patch: "If the CPUID limit bit in
MSR_IA32_MISC_ENABLE is set, clear it to make all CPUID
information available.  This is required for some features
to work, in particular XSAVE."

Originally-Developed-by: H. Peter Anvin <hpa@linux.intel.com>
Backported-by: Joe Korty <joe.korty@ccur.com>
Signed-off-by: Joe Korty <joe.korty@ccur.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 arch/x86/include/asm/msr-index.h |   29 +++++++++++++++++++++++++++++
 arch/x86/kernel/cpu/intel.c      |   13 +++++++++++++
 2 files changed, 42 insertions(+)

--- a/arch/x86/include/asm/msr-index.h
+++ b/arch/x86/include/asm/msr-index.h
@@ -200,6 +200,35 @@
 #define MSR_IA32_THERM_STATUS		0x0000019c
 #define MSR_IA32_MISC_ENABLE		0x000001a0
 
+/* MISC_ENABLE bits: architectural */
+#define MSR_IA32_MISC_ENABLE_FAST_STRING	(1ULL << 0)
+#define MSR_IA32_MISC_ENABLE_TCC		(1ULL << 1)
+#define MSR_IA32_MISC_ENABLE_EMON		(1ULL << 7)
+#define MSR_IA32_MISC_ENABLE_BTS_UNAVAIL	(1ULL << 11)
+#define MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL	(1ULL << 12)
+#define MSR_IA32_MISC_ENABLE_ENHANCED_SPEEDSTEP	(1ULL << 16)
+#define MSR_IA32_MISC_ENABLE_MWAIT		(1ULL << 18)
+#define MSR_IA32_MISC_ENABLE_LIMIT_CPUID	(1ULL << 22)
+#define MSR_IA32_MISC_ENABLE_XTPR_DISABLE	(1ULL << 23)
+#define MSR_IA32_MISC_ENABLE_XD_DISABLE		(1ULL << 34)
+
+/* MISC_ENABLE bits: model-specific, meaning may vary from core to core */
+#define MSR_IA32_MISC_ENABLE_X87_COMPAT		(1ULL << 2)
+#define MSR_IA32_MISC_ENABLE_TM1		(1ULL << 3)
+#define MSR_IA32_MISC_ENABLE_SPLIT_LOCK_DISABLE	(1ULL << 4)
+#define MSR_IA32_MISC_ENABLE_L3CACHE_DISABLE	(1ULL << 6)
+#define MSR_IA32_MISC_ENABLE_SUPPRESS_LOCK	(1ULL << 8)
+#define MSR_IA32_MISC_ENABLE_PREFETCH_DISABLE	(1ULL << 9)
+#define MSR_IA32_MISC_ENABLE_FERR		(1ULL << 10)
+#define MSR_IA32_MISC_ENABLE_FERR_MULTIPLEX	(1ULL << 10)
+#define MSR_IA32_MISC_ENABLE_TM2		(1ULL << 13)
+#define MSR_IA32_MISC_ENABLE_ADJ_PREF_DISABLE	(1ULL << 19)
+#define MSR_IA32_MISC_ENABLE_SPEEDSTEP_LOCK	(1ULL << 20)
+#define MSR_IA32_MISC_ENABLE_L1D_CONTEXT	(1ULL << 24)
+#define MSR_IA32_MISC_ENABLE_DCU_PREF_DISABLE	(1ULL << 37)
+#define MSR_IA32_MISC_ENABLE_TURBO_DISABLE	(1ULL << 38)
+#define MSR_IA32_MISC_ENABLE_IP_PREF_DISABLE	(1ULL << 39)
+
 /* Intel Model 6 */
 #define MSR_P6_EVNTSEL0			0x00000186
 #define MSR_P6_EVNTSEL1			0x00000187
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -30,6 +30,19 @@
 
 static void __cpuinit early_init_intel(struct cpuinfo_x86 *c)
 {
+	/* Unmask CPUID levels if masked: */
+	if (c->x86 == 6 && c->x86_model >= 15) {
+		u64 misc_enable;
+
+		rdmsrl(MSR_IA32_MISC_ENABLE, misc_enable);
+
+		if (misc_enable & MSR_IA32_MISC_ENABLE_LIMIT_CPUID) {
+			misc_enable &= ~MSR_IA32_MISC_ENABLE_LIMIT_CPUID;
+			wrmsrl(MSR_IA32_MISC_ENABLE, misc_enable);
+			c->cpuid_level = cpuid_eax(0);
+		}
+	}
+
 	if ((c->x86 == 0xf && c->x86_model >= 0x03) ||
 		(c->x86 == 0x6 && c->x86_model >= 0x0e))
 		set_cpu_cap(c, X86_FEATURE_CONSTANT_TSC);



  parent reply	other threads:[~2009-03-20 23:26 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090320222810.386844059@mini.kroah.org>
2009-03-20 23:21 ` [patch 00/43] 2.6.28.9-stable review Greg KH
2009-03-20 22:28   ` [patch 01/43] [IA64] Build fix for __early_pfn_to_nid() undefined link error Greg KH
2009-03-20 22:28   ` Greg KH [this message]
2009-03-20 22:28   ` [patch 03/43] eventfd: remove fput() call from possible IRQ context Greg KH
2009-03-20 22:28   ` [patch 04/43] S390: __div64_31 broken for CONFIG_MARCH_G5 Greg KH
2009-03-20 22:28   ` [patch 05/43] ALSA: Fix vunmap and free order in snd_free_sgbuf_pages() Greg KH
2009-03-20 22:28   ` [patch 06/43] ALSA: mixart, fix lock imbalance Greg KH
2009-03-20 22:28   ` [patch 07/43] ALSA: pcm_oss, fix locking typo Greg KH
2009-03-20 22:28   ` [patch 08/43] ALSA: hda - Fix DMA mask for ATI controllers Greg KH
2009-03-20 22:28   ` [patch 09/43] ALSA: hda - Workaround for buggy DMA position on " Greg KH
2009-03-20 22:28   ` [patch 10/43] ALSA: opl3sa2 - Fix NULL dereference when suspending snd_opl3sa2 Greg KH
2009-03-20 22:28   ` [patch 11/43] nfsd: nfsd should drop CAP_MKNOD for non-root Greg KH
2009-03-20 22:28   ` [patch 12/43] NFSD: provide encode routine for OP_OPENATTR Greg KH
2009-03-20 22:28   ` [patch 13/43] dm ioctl: validate name length when renaming Greg KH
2009-03-20 22:28   ` [patch 14/43] dm io: respect BIO_MAX_PAGES limit Greg KH
2009-03-20 22:28   ` [patch 15/43] dm crypt: fix kcryptd_async_done parameter Greg KH
2009-03-20 22:28   ` [patch 16/43] dm crypt: wait for endio to complete before destruction Greg KH
2009-03-20 22:28   ` [patch 17/43] ata_piix: add workaround for Samsung DB-P70 Greg KH
2009-03-20 22:28   ` [patch 18/43] V4L/DVB (10218): cx23885: Fix Oops for mixed install of analog and digital only cards Greg KH
2009-03-20 22:28   ` [patch 19/43] thinkpad-acpi: fix module autoloading for older models Greg KH
2009-03-20 22:28   ` [patch 20/43] Add -fwrapv to gcc CFLAGS Greg KH
2009-03-20 22:28   ` [patch 21/43] Move cc-option to below arch-specific setup Greg KH
2009-03-20 22:28   ` [patch 22/43] USB: storage: Unusual USB device Prolific 2507 variation added Greg KH
2009-03-20 22:28   ` [patch 23/43] USB: Add Vendor/Product ID for new CDMA U727 to option driver Greg KH
2009-03-20 22:28   ` [patch 24/43] USB: option.c: add ZTE 622 modem device Greg KH
2009-03-20 22:28   ` [patch 25/43] USB: Add device id for Option GTM380 to option driver Greg KH
2009-03-20 22:28   ` [patch 26/43] USB: Option: let cdc-acm handle Sony Ericsson F3507g / Dell 5530 Greg KH
2009-03-20 22:28   ` [patch 27/43] USB: Updated unusual-devs entry for USB mass storage on Nokia 6233 Greg KH
2009-03-20 22:28   ` [patch 28/43] USB: unusual_devs: Add support for GI 0431 SD-Card interface Greg KH
2009-03-20 22:28   ` [patch 29/43] USB: serial: add FTDI USB/Serial converter devices Greg KH
2009-03-20 22:28   ` [patch 30/43] USB: serial: ftdi: enable UART detection on gnICE JTAG adaptors blacklist interface0 Greg KH
2009-03-20 22:28   ` [patch 31/43] USB: serial: new cp2101 device id Greg KH
2009-03-20 22:28   ` [patch 32/43] USB: usbtmc: fix stupid bug in open() Greg KH
2009-03-20 22:28   ` [patch 33/43] USB: usbtmc: add protocol 1 support Greg KH
2009-03-20 22:28   ` [patch 34/43] USB: usbfs: keep async URBs until the device file is closed Greg KH
2009-03-20 22:28   ` [patch 35/43] USB: EHCI: expedite unlinks when the root hub is suspended Greg KH
2009-03-20 22:28   ` [patch 36/43] USB: EHCI: Fix isochronous URB leak Greg KH
2009-03-20 22:28   ` [patch 37/43] powerpc: Remove extra semicolon in fsl_soc.c Greg KH
2009-03-20 22:28   ` [patch 38/43] drm/i915: set vblank enabled flag correctly across IRQ install/uninstall Greg KH
2009-03-21  0:09     ` Eric Anholt
2009-03-21  0:43       ` Greg KH
2009-03-20 22:28   ` [patch 39/43] drm/i915: dont enable vblanks on disabled pipes Greg KH
2009-03-20 22:28   ` [patch 40/43] drm/i915: Dont double-unpin buffers if we take a signal in evict_everything() Greg KH
2009-03-20 22:28   ` [patch 41/43] drm/i915: Dont print to dmesg when taking signal during object_pin Greg KH
2009-03-20 22:28   ` [patch 42/43] drm/i915: Dont allow objects to get bound while VT switched Greg KH
2009-03-20 22:28   ` [patch 43/43] menu: fix embedded menu snafu Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090320222923.128981119@mini.kroah.org \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=eteo@redhat.com \
    --cc=hpa@linux.intel.com \
    --cc=jake@lwn.net \
    --cc=jmforbes@linuxtx.org \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mkrufky@linuxtv.org \
    --cc=rbranco@la.checkpoint.com \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome