From: Ingo Molnar <mingo@elte.hu>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Restrict definitions of a couple of static functions
Date: Sat, 21 Mar 2009 15:40:13 +0100 [thread overview]
Message-ID: <20090321144013.GB25729@elte.hu> (raw)
In-Reply-To: <1237644922-7877-1-git-send-email-dmitri.vorobiev@movial.com>
* Dmitri Vorobiev <dmitri.vorobiev@movial.com> wrote:
> The call sites of the static functions free_cache_attributes() and
> detect_cache_attributes() in arch/x86/kernel/cpu/intel_cacheinfo.c
> are placed under #ifdef CONFIG_SYSFS/#endif, but their definitions
> are not. This may produce the following warning:
>
> arch/x86/kernel/cpu/intel_cacheinfo.c:542: warning:
> 'free_cache_attributes' defined but not used
> arch/x86/kernel/cpu/intel_cacheinfo.c:573: warning:
> 'detect_cache_attributes' defined but not used
>
> This patch fixes the warning by restricting the definitions of the
> two functions to the case when CONFIG_SYSFS is enabled.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
> ---
> arch/x86/kernel/cpu/intel_cacheinfo.c | 64 ++++++++++++++++----------------
> 1 files changed, 32 insertions(+), 32 deletions(-)
does not apply to the latest x86 tree anymore:
http://people.redhat.com/mingo/tip.git/README
2 out of 3 hunks FAILED -- rejects in file arch/x86/kernel/cpu/intel_cacheinfo.c
Ingo
prev parent reply other threads:[~2009-03-21 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-21 14:15 Dmitri Vorobiev
2009-03-21 14:40 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090321144013.GB25729@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dmitri.vorobiev@movial.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®