From: Alexey Dobriyan <adobriyan@gmail.com>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH 07/12] DRBD: main
Date: Mon, 23 Mar 2009 19:51:26 +0300 [thread overview]
Message-ID: <20090323165126.GA2649@x200.localdomain> (raw)
In-Reply-To: <1237823287-12734-8-git-send-email-philipp.reisner@linbit.com>
On Mon, Mar 23, 2009 at 04:48:02PM +0100, Philipp Reisner wrote:
> +#if CONFIG_PROC_FS
> + /*
> + * register with procfs
> + */
> + drbd_proc = create_proc_entry("drbd", S_IFREG | S_IRUGO , NULL);
> +
> + if (!drbd_proc) {
> + printk(KERN_ERR "drbd: unable to register proc file\n");
> + goto Enomem;
> + }
> +
> + drbd_proc->proc_fops = &drbd_proc_fops;
Use proc_create().
> + drbd_proc->owner = THIS_MODULE;
Unnecessary now.
> +#else
> +# error "Currently drbd depends on the proc file system (CONFIG_PROC_FS)"
> +#endif
You should "depends on PROC_FS" then and remove this #error.
#ifdef would also become unnecessary.
next prev parent reply other threads:[~2009-03-23 16:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 15:47 [PATCH 00/12] DRBD: a block device for HA clusters Philipp Reisner
2009-03-23 15:47 ` [PATCH 01/12] DRBD: lru_cache Philipp Reisner
2009-03-23 15:47 ` [PATCH 02/12] DRBD: activity_log Philipp Reisner
2009-03-23 15:47 ` [PATCH 03/12] DRBD: bitmap Philipp Reisner
2009-03-23 15:47 ` [PATCH 04/12] DRBD: request Philipp Reisner
2009-03-23 15:48 ` [PATCH 05/12] DRBD: userspace_interface Philipp Reisner
2009-03-23 15:48 ` [PATCH 06/12] DRBD: internal_data_structures Philipp Reisner
2009-03-23 15:48 ` [PATCH 07/12] DRBD: main Philipp Reisner
2009-03-23 15:48 ` [PATCH 08/12] DRBD: receiver Philipp Reisner
2009-03-23 15:48 ` [PATCH 09/12] DRBD: proc Philipp Reisner
2009-03-23 15:48 ` [PATCH 10/12] DRBD: worker Philipp Reisner
2009-03-23 15:48 ` [PATCH 11/12] DRBD: misc Philipp Reisner
2009-03-23 15:48 ` [PATCH 12/12] DRBD: final Philipp Reisner
2009-04-08 10:17 ` [PATCH 08/12] DRBD: receiver Nikanth K
2009-04-08 15:10 ` Philipp Reisner
2009-03-23 16:51 ` Alexey Dobriyan [this message]
2009-03-23 22:26 ` [PATCH 07/12] DRBD: main Philipp Reisner
2009-04-08 10:16 ` [PATCH 04/12] DRBD: request Nikanth K
2009-04-08 10:16 ` [PATCH 03/12] DRBD: bitmap Nikanth K
2009-04-08 15:09 ` Philipp Reisner
2009-03-24 12:27 ` [PATCH 02/12] DRBD: activity_log Andi Kleen
2009-03-25 10:27 ` Philipp Reisner
2009-03-25 10:46 ` Andi Kleen
2009-03-25 10:57 ` Philipp Reisner
2009-03-23 15:58 ` [PATCH 01/12] DRBD: lru_cache Greg KH
2009-04-08 10:15 ` Nikanth K
2009-04-08 15:09 ` Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323165126.GA2649@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®